Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1507663003: Isolate gin_unittests and add them to bots (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Isolate gin_unittests and add them to bots BUG=389460 R=phajdan.jr@chromium.org Committed: https://crrev.com/656a7c9458cb94bf312dcfcb71bf5f04a72dcb01 Cr-Commit-Position: refs/heads/master@{#363650}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -18 lines) Patch
M gin/BUILD.gn View 1 3 chunks +29 lines, -0 lines 0 comments Download
M gin/gin.gyp View 2 chunks +20 lines, -0 lines 0 comments Download
A + gin/gin_unittests.isolate View 1 1 chunk +21 lines, -18 lines 0 comments Download
M gin/shell/gin_shell_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-12-07 16:22:25 UTC) #1
Paweł Hajdan Jr.
LGTM w/comment https://codereview.chromium.org/1507663003/diff/1/gin/gin_unittests.isolate File gin/gin_unittests.isolate (right): https://codereview.chromium.org/1507663003/diff/1/gin/gin_unittests.isolate#newcode13 gin/gin_unittests.isolate:13: '../OWNERS', Why is this needed?
5 years ago (2015-12-07 16:25:40 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1507663003/diff/1/gin/gin_unittests.isolate File gin/gin_unittests.isolate (right): https://codereview.chromium.org/1507663003/diff/1/gin/gin_unittests.isolate#newcode13 gin/gin_unittests.isolate:13: '../OWNERS', On 2015/12/07 at 16:25:40, Paweł Hajdan Jr. wrote: ...
5 years ago (2015-12-07 16:29:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507663003/1
5 years ago (2015-12-07 16:29:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/151463)
5 years ago (2015-12-07 17:21:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507663003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507663003/20001
5 years ago (2015-12-07 22:12:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-08 00:56:52 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-08 00:57:51 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/656a7c9458cb94bf312dcfcb71bf5f04a72dcb01
Cr-Commit-Position: refs/heads/master@{#363650}

Powered by Google App Engine
This is Rietveld 408576698