Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: gin/BUILD.gn

Issue 1507663003: Isolate gin_unittests and add them to bots (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gin/gin.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/BUILD.gn
diff --git a/gin/BUILD.gn b/gin/BUILD.gn
index 0b270c5894aa24aa21c286282d74b3adc8941d1f..fb16d3a2e03d29c560770d4897746e1029dcf13c 100644
--- a/gin/BUILD.gn
+++ b/gin/BUILD.gn
@@ -135,6 +135,8 @@ executable("gin_shell") {
"//build/config/sanitizers:deps",
"//v8",
]
+
+ configs += [ "//v8:external_startup_data" ]
}
source_set("gin_test") {
@@ -159,6 +161,8 @@ source_set("gin_test") {
deps = [
"//v8",
]
+
+ configs += [ "//v8:external_startup_data" ]
}
test("gin_unittests") {
@@ -177,8 +181,33 @@ test("gin_unittests") {
]
deps = [
+ ":gin_shell",
":gin_test",
"//base/test:test_support",
"//v8",
]
+
+ configs += [ "//v8:external_startup_data" ]
+
+ data = [
+ "modules/module_registry_unittests.js",
+ "shell/hello_world.js",
+ "test/expect.js",
+ "test/file_unittests.js",
+ "test/gtest_unittests.js",
+ "../OWNERS",
+ ]
+
+ data_deps = [
+ ":gin_shell",
+ ]
+}
+
+# TODO(GYP): Delete this after we've converted everything to GN.
+# The _run targets exist only for compatibility w/ GYP.
+group("gin_unittests_run") {
+ testonly = true
+ deps = [
+ ":gin_unittests",
+ ]
}
« no previous file with comments | « no previous file | gin/gin.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698