Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1507653002: Remove clearing of pending invalidation sets. (Closed)

Created:
5 years ago by rune
Modified:
5 years ago
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove clearing of pending invalidation sets. In preparation for making SubtreeStyleChange not affect the sibling forest. We can skip scheduling descendant invalidation sets for elements whose styleChangeType is SubtreeStyleChange. However, with sibling invalidation sets, we still need to schedule invalidations for invalidating the sibling forest when we change SubtreeStyleChange to be a strict subtree recalc. We may not clear pending invalidations on detach either, unless the node was actually removed from the dom tree, since there might be pending sibling invalidations. R=dstockwell@chromium.org,ericwilligers@chromium.org BUG=557440 Committed: https://crrev.com/c0735df3d8f8efa24af168a6e8d5c02a7be0641c Cr-Commit-Position: refs/heads/master@{#364064}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp View 1 1 chunk +12 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
rune
ptal
5 years ago (2015-12-07 13:45:49 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507653002/1
5 years ago (2015-12-07 13:45:56 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/151360)
5 years ago (2015-12-07 14:39:30 UTC) #5
rune
On 2015/12/07 14:39:30, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
5 years ago (2015-12-07 14:49:22 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507653002/20001
5 years ago (2015-12-07 15:33:31 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/151394)
5 years ago (2015-12-07 16:16:54 UTC) #11
rune
Ready for review now.
5 years ago (2015-12-08 09:51:49 UTC) #12
rune
ptal
5 years ago (2015-12-09 08:26:54 UTC) #13
Eric Willigers
lgtm
5 years ago (2015-12-09 12:33:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507653002/20001
5 years ago (2015-12-09 13:13:49 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-09 14:57:37 UTC) #20
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c0735df3d8f8efa24af168a6e8d5c02a7be0641c Cr-Commit-Position: refs/heads/master@{#364064}
5 years ago (2015-12-09 14:58:30 UTC) #22
wkorman
5 years ago (2015-12-10 18:56:33 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1518793002/ by wkorman@chromium.org.

The reason for reverting is: Suspect root cause of crash in
blink::StyleInvalidator::pushInvalidationSetsForElement

http://crbug.com/568502.

Powered by Google App Engine
This is Rietveld 408576698