Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1507653002:
Remove clearing of pending invalidation sets. (Closed)
|
Created:
5 years ago by rune Modified:
5 years ago CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove clearing of pending invalidation sets.
In preparation for making SubtreeStyleChange not affect the sibling
forest.
We can skip scheduling descendant invalidation sets for elements whose
styleChangeType is SubtreeStyleChange. However, with sibling invalidation
sets, we still need to schedule invalidations for invalidating the
sibling forest when we change SubtreeStyleChange to be a strict subtree
recalc.
We may not clear pending invalidations on detach either, unless the node
was actually removed from the dom tree, since there might be pending
sibling invalidations.
R=dstockwell@chromium.org,ericwilligers@chromium.org
BUG=557440
Committed: https://crrev.com/c0735df3d8f8efa24af168a6e8d5c02a7be0641c
Cr-Commit-Position: refs/heads/master@{#364064}
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 23 (10 generated)
The CQ bit was checked by rune@opera.com to run a CQ dry run
ptal
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507653002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2015/12/07 14:39:30, commit-bot: I haz the power wrote: > Dry run: Try jobs failed on following builders: > linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) I've introduce an assert. Hold review for now.
The CQ bit was checked by rune@opera.com to run a CQ dry run
Description was changed from ========== Remove clearing of pending invalidation sets. In preparation for making SubtreeStyleChange not affect the sibling forest. We can skip scheduling descendant invalidation sets for elements whose styleChangeType is SubtreeStyleChange. However, with sibling invalidation sets, we still need to schedule invalidations for invalidating the sibling forest when we change SubtreeStyleChange to be a strict subtree recalc. We may not clear pending invalidations on detach either, since there might be pending sibling invalidations. R=dstockwell@chromium.org,ericwilligers@chromium.org BUG=557440 ========== to ========== Remove clearing of pending invalidation sets. In preparation for making SubtreeStyleChange not affect the sibling forest. We can skip scheduling descendant invalidation sets for elements whose styleChangeType is SubtreeStyleChange. However, with sibling invalidation sets, we still need to schedule invalidations for invalidating the sibling forest when we change SubtreeStyleChange to be a strict subtree recalc. We may not clear pending invalidations on detach either, unless the node was actually removed from the dom tree, since there might be pending sibling invalidations. R=dstockwell@chromium.org,ericwilligers@chromium.org BUG=557440 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507653002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Ready for review now.
ptal
The CQ bit was checked by ericwilligers@chromium.org
The CQ bit was unchecked by ericwilligers@chromium.org
lgtm
The CQ bit was checked by rune@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507653002/20001
Message was sent while issue was closed.
Description was changed from ========== Remove clearing of pending invalidation sets. In preparation for making SubtreeStyleChange not affect the sibling forest. We can skip scheduling descendant invalidation sets for elements whose styleChangeType is SubtreeStyleChange. However, with sibling invalidation sets, we still need to schedule invalidations for invalidating the sibling forest when we change SubtreeStyleChange to be a strict subtree recalc. We may not clear pending invalidations on detach either, unless the node was actually removed from the dom tree, since there might be pending sibling invalidations. R=dstockwell@chromium.org,ericwilligers@chromium.org BUG=557440 ========== to ========== Remove clearing of pending invalidation sets. In preparation for making SubtreeStyleChange not affect the sibling forest. We can skip scheduling descendant invalidation sets for elements whose styleChangeType is SubtreeStyleChange. However, with sibling invalidation sets, we still need to schedule invalidations for invalidating the sibling forest when we change SubtreeStyleChange to be a strict subtree recalc. We may not clear pending invalidations on detach either, unless the node was actually removed from the dom tree, since there might be pending sibling invalidations. R=dstockwell@chromium.org,ericwilligers@chromium.org BUG=557440 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove clearing of pending invalidation sets. In preparation for making SubtreeStyleChange not affect the sibling forest. We can skip scheduling descendant invalidation sets for elements whose styleChangeType is SubtreeStyleChange. However, with sibling invalidation sets, we still need to schedule invalidations for invalidating the sibling forest when we change SubtreeStyleChange to be a strict subtree recalc. We may not clear pending invalidations on detach either, unless the node was actually removed from the dom tree, since there might be pending sibling invalidations. R=dstockwell@chromium.org,ericwilligers@chromium.org BUG=557440 ========== to ========== Remove clearing of pending invalidation sets. In preparation for making SubtreeStyleChange not affect the sibling forest. We can skip scheduling descendant invalidation sets for elements whose styleChangeType is SubtreeStyleChange. However, with sibling invalidation sets, we still need to schedule invalidations for invalidating the sibling forest when we change SubtreeStyleChange to be a strict subtree recalc. We may not clear pending invalidations on detach either, unless the node was actually removed from the dom tree, since there might be pending sibling invalidations. R=dstockwell@chromium.org,ericwilligers@chromium.org BUG=557440 Committed: https://crrev.com/c0735df3d8f8efa24af168a6e8d5c02a7be0641c Cr-Commit-Position: refs/heads/master@{#364064} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c0735df3d8f8efa24af168a6e8d5c02a7be0641c Cr-Commit-Position: refs/heads/master@{#364064}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1518793002/ by wkorman@chromium.org. The reason for reverting is: Suspect root cause of crash in blink::StyleInvalidator::pushInvalidationSetsForElement http://crbug.com/568502. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
