Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 1507653002: Remove clearing of pending invalidation sets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1512 matching lines...) Expand 10 before | Expand all | Expand 10 after
1523 clearElementFlag(IsInCanvasSubtree); 1523 clearElementFlag(IsInCanvasSubtree);
1524 1524
1525 if (hasRareData()) { 1525 if (hasRareData()) {
1526 ElementRareData* data = elementRareData(); 1526 ElementRareData* data = elementRareData();
1527 1527
1528 data->clearRestyleFlags(); 1528 data->clearRestyleFlags();
1529 1529
1530 if (ElementAnimations* elementAnimations = data->elementAnimations()) 1530 if (ElementAnimations* elementAnimations = data->elementAnimations())
1531 elementAnimations->cssAnimations().cancel(); 1531 elementAnimations->cssAnimations().cancel();
1532 } 1532 }
1533
1534 document().styleEngine().styleInvalidator().clearInvalidation(*this);
1533 } 1535 }
1534 1536
1535 void Element::attach(const AttachContext& context) 1537 void Element::attach(const AttachContext& context)
1536 { 1538 {
1537 ASSERT(document().inStyleRecalc()); 1539 ASSERT(document().inStyleRecalc());
1538 1540
1539 // We've already been through detach when doing an attach, but we might 1541 // We've already been through detach when doing an attach, but we might
1540 // need to clear any state that's been added since then. 1542 // need to clear any state that's been added since then.
1541 if (hasRareData() && styleChangeType() == NeedsReattachStyleChange) { 1543 if (hasRareData() && styleChangeType() == NeedsReattachStyleChange) {
1542 ElementRareData* data = elementRareData(); 1544 ElementRareData* data = elementRareData();
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
1609 ContainerNode::detach(context); 1611 ContainerNode::detach(context);
1610 1612
1611 if (!context.performingReattach && isUserActionElement()) { 1613 if (!context.performingReattach && isUserActionElement()) {
1612 if (hovered()) 1614 if (hovered())
1613 document().hoveredNodeDetached(*this); 1615 document().hoveredNodeDetached(*this);
1614 if (inActiveChain()) 1616 if (inActiveChain())
1615 document().activeChainNodeDetached(*this); 1617 document().activeChainNodeDetached(*this);
1616 document().userActionElements().didDetach(*this); 1618 document().userActionElements().didDetach(*this);
1617 } 1619 }
1618 1620
1619 document().styleEngine().styleInvalidator().clearInvalidation(*this);
1620
1621 if (svgFilterNeedsLayerUpdate()) 1621 if (svgFilterNeedsLayerUpdate())
1622 document().unscheduleSVGFilterLayerUpdateHack(*this); 1622 document().unscheduleSVGFilterLayerUpdateHack(*this);
1623 1623
1624 ASSERT(needsAttach()); 1624 ASSERT(needsAttach());
1625 } 1625 }
1626 1626
1627 bool Element::pseudoStyleCacheIsInvalid(const ComputedStyle* currentStyle, Compu tedStyle* newStyle) 1627 bool Element::pseudoStyleCacheIsInvalid(const ComputedStyle* currentStyle, Compu tedStyle* newStyle)
1628 { 1628 {
1629 ASSERT(currentStyle == computedStyle()); 1629 ASSERT(currentStyle == computedStyle());
1630 ASSERT(layoutObject()); 1630 ASSERT(layoutObject());
(...skipping 1985 matching lines...) Expand 10 before | Expand all | Expand 10 after
3616 { 3616 {
3617 #if ENABLE(OILPAN) 3617 #if ENABLE(OILPAN)
3618 if (hasRareData()) 3618 if (hasRareData())
3619 visitor->trace(elementRareData()); 3619 visitor->trace(elementRareData());
3620 visitor->trace(m_elementData); 3620 visitor->trace(m_elementData);
3621 #endif 3621 #endif
3622 ContainerNode::trace(visitor); 3622 ContainerNode::trace(visitor);
3623 } 3623 }
3624 3624
3625 } // namespace blink 3625 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698