extract named constructor suggestions from prefixed element contributor

extract named constructor suggestions from prefixed element contributor

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/55a8740ba12f94627c1a4ddbbbb329220416ed2b

[danrubel, 2015-12-07 13:10:39]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-12-07 16:16:15]

lgtm

https://codereview.chromium.org/1507633002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
(right):

https://codereview.chromium.org/1507633002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart:103:
Future<LibraryElement> resolveContainingLibrary() async {
It seems that the documentation for the method and its implementation don't
agree.
This method does not return the fully resolved LibraryElement.
But the documentation does not mention this.

https://codereview.chromium.org/1507633002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart
(right):

https://codereview.chromium.org/1507633002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart:17:
* `completion.getSuggestions` request results.
Is the comment valid?

[danrubel, 2015-12-07 16:58:43]

Description was changed from

==========
extract named constructor suggestions from prefixed element contributor
==========

to

==========
extract named constructor suggestions from prefixed element contributor

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/55a8740ba12f94627c1a4ddbbbb329220416ed2b
==========

[danrubel, 2015-12-07 16:58:44]

Committed patchset #3 (id:40001) manually as
55a8740ba12f94627c1a4ddbbbb329220416ed2b (presubmit successful).

[danrubel, 2015-12-07 16:59:38]

https://codereview.chromium.org/1507633002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
(right):

https://codereview.chromium.org/1507633002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart:103:
Future<LibraryElement> resolveContainingLibrary() async {
On 2015/12/07 16:16:15, scheglov wrote:
> It seems that the documentation for the method and its implementation don't
> agree.
> This method does not return the fully resolved LibraryElement.
> But the documentation does not mention this.

Good point. This is not meant to resolve the library element, just return it. 
Renamed accessor to `libraryElement` and updated doc to reflect this.

https://codereview.chromium.org/1507633002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart
(right):

https://codereview.chromium.org/1507633002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart:17:
* `completion.getSuggestions` request results.
On 2015/12/07 16:16:15, scheglov wrote:
> Is the comment valid?

Fixed.