pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart - Issue 1507633002: extract named constructor suggestions from prefixed element contributor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

Issue 1507633002: extract named constructor suggestions from prefixed element contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart ('k') | pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart b/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

index b6fe585de589e2f41ffafc4016540fccd674bc2d..23657fdedef0bd07638c2ad415ac5ea000b0781c 100644

--- a/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

@@ -264,11 +264,6 @@ class _PrefixedIdentifierSuggestionBuilder

@override

Future<bool> computeFull(AstNode node) {

- if (node is ConstructorName) {

- // some PrefixedIdentifier nodes are transformed into

- // ConstructorName nodes during the resolution process.

- return new NamedConstructorSuggestionBuilder(request).computeFull(node);

- }

if (node is PrefixedIdentifier) {

SimpleIdentifier prefix = node.prefix;

if (prefix != null) {