|
Clean up dns prefetch code, and also port it.
- remove slave threads and use HostResolver in asynchronous mode instead (while still limiting number of concurrent lookups)
- make the implementation portable and make DnsMaster unit test compile and pass on Linux
- add more tests to DnsMaster unit test to simulate various shutdown scenarios, concurrent lookups, and to verify that we don't exceed our limit of concurrent lookup requests)
- remove some tests which relied on specifics of slaves' inner working
- adjust initialization and shutdown of dns prefetching (now it relies on the IO message loop being present)
Bonus: shutdown is almost instant now, no need to have a timeout.
BUG= 5687, 6683
Total comments: 2
Total comments: 7
Total comments: 13
Total comments: 7
Total comments: 2
Total comments: 6
Total comments: 1
Total comments: 3
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+418 lines, -825 lines) |
Patch |
 |
M |
chrome/browser/browser.scons
|
View
|
1
2
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browser.vcproj
|
View
|
9
10
11
12
13
14
15
16
17
18
19
20
|
1 chunk |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browser_main.cc
|
View
|
18
19
20
21
22
|
4 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browser_prefs.cc
|
View
|
|
4 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browser_process_impl.cc
|
View
|
18
19
20
21
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chrome_plugin_host.cc
|
View
|
18
19
20
21
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/net/dns_global.h
|
View
|
18
19
20
21
22
|
2 chunks |
+12 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/net/dns_global.cc
|
View
|
1
2
9
10
11
12
13
14
15
16
17
18
19
20
21
|
2 chunks |
+7 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/net/dns_host_info.h
|
View
|
|
2 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/net/dns_host_info.cc
|
View
|
10
11
12
13
14
15
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/net/dns_host_info_unittest.cc
|
View
|
10
11
12
13
14
15
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/net/dns_master.h
|
View
|
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
|
5 chunks |
+56 lines, -101 lines |
1 comment
|
Download
|
 |
M |
chrome/browser/net/dns_master.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
|
9 chunks |
+116 lines, -202 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/net/dns_master_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
|
14 chunks |
+192 lines, -285 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/net/dns_slave.h
|
View
|
1
2
3
4
5
6
|
1 chunk |
+0 lines, -72 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/net/dns_slave.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+0 lines, -96 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome.xcodeproj/project.pbxproj
|
View
|
19
20
|
5 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/common/temp_scaffolding_stubs.cc
|
View
|
18
19
20
|
4 chunks |
+3 lines, -23 lines |
0 comments
|
Download
|
 |
M |
chrome/test/unit/unit_tests.scons
|
View
|
1
2
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
net/base/host_resolver.h
|
View
|
4
5
6
7
8
9
10
11
12
13
14
15
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
Total messages: 49 (0 generated)
|