Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 19534: Fix HostResolver crash when MessageLoop is destroyed during (Closed)

Created:
11 years, 10 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix HostResolver crash when MessageLoop is destroyed during asynchronous resolution. This should hopefully fix reliability failures introduced in r9312. TBR=darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9317

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M net/base/host_resolver.cc View 1 6 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
I'm not sure if it's done the best way (many calls to Remove...Observer in many ...
11 years, 10 months ago (2009-02-02 12:00:43 UTC) #1
darin (slow to review)
I'm having a hard time following what crash this change is attempting to avoid. Can ...
11 years, 10 months ago (2009-02-02 19:17:43 UTC) #2
darin (slow to review)
11 years, 10 months ago (2009-02-05 22:39:04 UTC) #3
so, we decided that this CL is no longer needed right?

Powered by Google App Engine
This is Rietveld 408576698