Issue 150743002: Replace factory generation of TextContexts with persistent objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150743002: Replace factory generation of TextContexts with persistent objects. (Closed)

Created:
6 years, 10 months ago by jvanverth1

Modified:
6 years, 10 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Replace factory generation of TextContexts with persistent objects. BUG=skia:2018 Committed: http://code.google.com/p/skia/source/detail?r=13249

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+145 lines, -160 lines)			Patch
M	include/gpu/SkGpuDevice.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/gpu/GrBitmapTextContext.h	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	src/gpu/GrBitmapTextContext.cpp	View	8 chunks	+35 lines, -9 lines	0 comments	Download
M	src/gpu/GrDistanceFieldTextContext.h	View	1 chunk	+10 lines, -8 lines	0 comments	Download
M	src/gpu/GrDistanceFieldTextContext.cpp	View	7 chunks	+45 lines, -20 lines	0 comments	Download
M	src/gpu/GrTextContext.h	View	1 chunk	+13 lines, -86 lines	0 comments	Download
M	src/gpu/GrTextContext.cpp	View	1 chunk	+11 lines, -8 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	9 chunks	+20 lines, -23 lines	0 comments	Download

Total messages: 5 (0 generated)

jvanverth1

This went a lot smoother than the last time I tried -- having the uniform ...

6 years, 10 months ago (2014-01-30 20:33:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/150743002/40001

6 years, 10 months ago (2014-01-30 21:25:26 UTC) #3

commit-bot: I haz the power

6 years, 10 months ago (2014-01-30 22:06:23 UTC) #5

Message was sent while issue was closed.

CQ bit was unchecked on CL. Ignoring.