Issue 1507343013: Run tests on Chrome stable by default

Issue 1507343013: Run tests on Chrome stable by default (Closed)

Created:
5 years ago by vsm

Modified:
5 years ago

Reviewers:
Jennifer Messerly, ochafik

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Run tests on Chrome stable by default This also disables destructuring by default as Chrome 47 (current stable) does not support. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/040ce468905f257aa8d22490b342b768a045e0d9

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -38 lines)			Patch
M	karma.conf.js	View	3 chunks	+6 lines, -18 lines	0 comments	Download
M	lib/src/codegen/js_codegen.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	lib/src/options.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/codegen/expect/closure.js	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	test/codegen/expect/collection/algorithms.js	View	3 chunks	+10 lines, -3 lines	0 comments	Download
M	test/codegen/expect/collection/src/canonicalized_map.js	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	test/codegen/expect/collection/wrappers.js	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	test/codegen/expect/constructors.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/codegen/expect/methods.js	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	test/codegen/expect/temps.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/codegen/expect/unittest.js	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	test/codegen/expect/unittest/unittest.js	View	2 chunks	+6 lines, -2 lines	0 comments	Download

Total messages: 6 (3 generated)

Jennifer Messerly

LGTM. the option can still be turned on right? Should we open a bug for ...

5 years ago (2015-12-11 20:07:08 UTC) #4

vsm

5 years ago (2015-12-11 20:18:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
040ce468905f257aa8d22490b342b768a045e0d9 (presubmit successful).