lib/src/codegen/js_codegen.dart - Issue 1507343013: Run tests on Chrome stable by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1507343013: Run tests on Chrome stable by default (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/js_codegen.dart

diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart

index 85a64ebe24579a277b4a306516983183905a2b10..09c730425d6d09c114fe9ce84777c92c259310e8 100644

--- a/lib/src/codegen/js_codegen.dart

+++ b/lib/src/codegen/js_codegen.dart

@@ -1990,8 +1990,9 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ClosureAnnotator {

/// We cannot destructure named params that clash with JS reserved names:

/// see discussion in https://github.com/dart-lang/dev_compiler/issues/392.

bool _isDestructurableNamedParam(FormalParameter param) =>

- _isNamedParam(param) && !invalidVariableName(param.identifier.name) &&

- options.destructureNamedParams;

+ _isNamedParam(param) &&

+ !invalidVariableName(param.identifier.name) &&

+ options.destructureNamedParams;

@override

List<JS.Parameter> visitFormalParameterList(FormalParameterList node) =>

« no previous file with comments | « karma.conf.js ('k') | lib/src/options.dart » ('j') | no next file with comments »