Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1507303002: extract LibraryMemberContributor from prefixed element contributor (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

extract LibraryMemberContributor from prefixed element contributor R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/dcacf6145bc50ea5cc94735885afa592a3eb7fa0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+467 lines, -56 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 1 chunk +1 line, -5 lines 0 comments Download
A pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart View 1 chunk +201 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart View 1 chunk +28 lines, -25 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +23 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 3 chunks +10 lines, -7 lines 0 comments Download
A pkg/analysis_server/test/services/completion/dart/library_member_contributor_test.dart View 1 chunk +177 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/named_constructor_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/static_member_contributor_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/prefixed_element_contributor_test.dart View 5 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-08 17:25:07 UTC) #2
scheglov
LGTM
5 years ago (2015-12-08 18:41:59 UTC) #3
danrubel
5 years ago (2015-12-08 20:10:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dcacf6145bc50ea5cc94735885afa592a3eb7fa0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698