pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart - Issue 1507303002: extract LibraryMemberContributor from prefixed element contributor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart

Issue 1507303002: extract LibraryMemberContributor from prefixed element contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart ('k') | pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart

index 4aebda707dcf5e7322da3791f9fc4ac975def48d..86f841e368322c50dfadcea3b97fb6f36398a648 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart

@@ -5,7 +5,6 @@

library services.completion.contributor.dart.static_member;

import 'dart:async';

-import 'dart:collection';

import 'package:analysis_server/src/provisional/completion/dart/completion_dart.dart';

import 'package:analysis_server/src/provisional/completion/dart/completion_target.dart';

@@ -17,7 +16,7 @@ import '../../../protocol_server.dart'

show CompletionSuggestion, CompletionSuggestionKind;

/**

- * A contributor for calculating invocation / access suggestions

+ * A contributor for calculating static member invocation / access suggestions

* `completion.getSuggestions` request results.

class StaticMemberContributor extends DartCompletionContributor {

@@ -32,7 +31,7 @@ class StaticMemberContributor extends DartCompletionContributor {

}

// Resolve the expression and the containing library

- await request.resolveIdentifier(targetId);

+ await request.resolveExpression(targetId);

LibraryElement containingLibrary = await request.libraryElement;

// Gracefully degrade if the library could not be determined

// e.g. detached part file or source change