Make Error.prototype.toString spec compliant; and fix various side-effect-free error printing metho…

Make Error.prototype.toString spec compliant; and fix various side-effect-free error printing methods

R=yangguo@chromium.org
LOG=n

Committed: https://crrev.com/5dffa35350d0f57402806e6bd87a914e1d5933e4
Cr-Commit-Position: refs/heads/master@{#32695}

Committed: https://crrev.com/454c1faeef2e3415e5d4760a9122c56675936d2b
Cr-Commit-Position: refs/heads/master@{#32720}

[Toon Verwaest, 2015-12-08 14:26:26]

ptal

[Yang, 2015-12-08 14:38:15]

LGTM.

https://codereview.chromium.org/1507273002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1507273002/diff/20001/src/api.cc#newcode2900
src/api.cc:2900: MaybeLocal<String> Value::ToDetailString(Local<Context>
context) const {
maybe we don't have to expose this anymore? Chrome does not use it.

https://codereview.chromium.org/1507273002/diff/20001/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/1507273002/diff/20001/src/ast/scopes.cc#newco...
src/ast/scopes.cc:1161: V8_Fatal(__FILE__, __LINE__, "Unbound variable: '%s' in
native script.",
nice.

[Toon Verwaest, 2015-12-09 06:57:20]

Description was changed from

==========
Make Error.prototype.toString spec compliant; and fix various side-effect-free
error printing methods

R=yangguo@chromium.org
BUG=v8:4002
LOG=n
==========

to

==========
Make Error.prototype.toString spec compliant; and fix various side-effect-free
error printing methods

R=yangguo@chromium.org
LOG=n
==========

[Toon Verwaest, 2015-12-09 07:57:57]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2015-12-09 07:58:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507273002/20001

[Benedikt Meurer, 2015-12-09 08:02:56]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2015-12-09 08:02:56]

LGTM (rubberstamped)

[commit-bot: I haz the power, 2015-12-09 08:52:07]

Description was changed from

==========
Make Error.prototype.toString spec compliant; and fix various side-effect-free
error printing methods

R=yangguo@chromium.org
LOG=n
==========

to

==========
Make Error.prototype.toString spec compliant; and fix various side-effect-free
error printing methods

R=yangguo@chromium.org
LOG=n
==========

[commit-bot: I haz the power, 2015-12-09 08:52:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-09 08:52:31]

Description was changed from

==========
Make Error.prototype.toString spec compliant; and fix various side-effect-free
error printing methods

R=yangguo@chromium.org
LOG=n
==========

to

==========
Make Error.prototype.toString spec compliant; and fix various side-effect-free
error printing methods

R=yangguo@chromium.org
LOG=n

Committed: https://crrev.com/5dffa35350d0f57402806e6bd87a914e1d5933e4
Cr-Commit-Position: refs/heads/master@{#32695}
==========

[commit-bot: I haz the power, 2015-12-09 08:52:32]

Patchset 2 (id:??) landed as
https://crrev.com/5dffa35350d0f57402806e6bd87a914e1d5933e4
Cr-Commit-Position: refs/heads/master@{#32695}

[Michael Achenbach, 2015-12-09 10:22:26]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1510173002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks layout tests. Please rebase
upstream first:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

[Toon Verwaest, 2015-12-09 13:02:42]

Description was changed from

==========
Make Error.prototype.toString spec compliant; and fix various side-effect-free
error printing methods

R=yangguo@chromium.org
LOG=n

Committed: https://crrev.com/5dffa35350d0f57402806e6bd87a914e1d5933e4
Cr-Commit-Position: refs/heads/master@{#32695}
==========

to

==========
Make Error.prototype.toString spec compliant; and fix various side-effect-free
error printing methods

R=yangguo@chromium.org
LOG=n

Committed: https://crrev.com/5dffa35350d0f57402806e6bd87a914e1d5933e4
Cr-Commit-Position: refs/heads/master@{#32695}
==========

[Toon Verwaest, 2015-12-09 13:30:05]

ptal again

[Yang, 2015-12-09 13:31:11]

On 2015/12/09 13:30:05, Toon Verwaest wrote:
> ptal again

lgtm.

[Toon Verwaest, 2015-12-09 13:57:10]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-12-09 13:57:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1507273002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-12-09 13:57:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507273002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507273002/120001

[Toon Verwaest, 2015-12-09 14:17:09]

The CQ bit was unchecked by verwaest@chromium.org

[Yang, 2015-12-09 15:08:10]

still lgtm

https://codereview.chromium.org/1507273002/diff/140001/src/messages.cc
File src/messages.cc (right):

https://codereview.chromium.org/1507273002/diff/140001/src/messages.cc#newcode89
src/messages.cc:89: if (Object::IsErrorObject(isolate, argument)) {
this also happens if the user creates an Error object via new Error, right? so
this doesnt guarantee that it's an internally thrown error.

we *could* do the distinction though, if we want, e.g. by installing some
private symbol on the code path for internally thrown errors...

[Toon Verwaest, 2015-12-09 15:50:54]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-12-09 15:50:54]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1507273002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-12-09 15:50:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507273002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507273002/140001

[commit-bot: I haz the power, 2015-12-09 17:00:53]

Description was changed from

==========
Make Error.prototype.toString spec compliant; and fix various side-effect-free
error printing methods

R=yangguo@chromium.org
LOG=n

Committed: https://crrev.com/5dffa35350d0f57402806e6bd87a914e1d5933e4
Cr-Commit-Position: refs/heads/master@{#32695}
==========

to

==========
Make Error.prototype.toString spec compliant; and fix various side-effect-free
error printing methods

R=yangguo@chromium.org
LOG=n

Committed: https://crrev.com/5dffa35350d0f57402806e6bd87a914e1d5933e4
Cr-Commit-Position: refs/heads/master@{#32695}
==========

[commit-bot: I haz the power, 2015-12-09 17:00:53]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-12-09 17:03:15]

Description was changed from

==========
Make Error.prototype.toString spec compliant; and fix various side-effect-free
error printing methods

R=yangguo@chromium.org
LOG=n

Committed: https://crrev.com/5dffa35350d0f57402806e6bd87a914e1d5933e4
Cr-Commit-Position: refs/heads/master@{#32695}
==========

to

==========
Make Error.prototype.toString spec compliant; and fix various side-effect-free
error printing methods

R=yangguo@chromium.org
LOG=n

Committed: https://crrev.com/5dffa35350d0f57402806e6bd87a914e1d5933e4
Cr-Commit-Position: refs/heads/master@{#32695}

Committed: https://crrev.com/454c1faeef2e3415e5d4760a9122c56675936d2b
Cr-Commit-Position: refs/heads/master@{#32720}
==========

[commit-bot: I haz the power, 2015-12-09 17:03:16]

Patchset 8 (id:??) landed as
https://crrev.com/454c1faeef2e3415e5d4760a9122c56675936d2b
Cr-Commit-Position: refs/heads/master@{#32720}