Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: src/isolate.h

Issue 1507273002: Make Error.prototype.toString spec compliant; and fix various side-effect-free error printing metho… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/execution.cc ('k') | src/isolate.cc » ('j') | src/messages.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index 6fb325af796284c3a7aed9c64d7122d0fc275655..ffd4c9caa806f614fa0d9d386d9e0b96e6be285d 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -947,10 +947,6 @@ class Isolate {
date_cache_ = date_cache;
}
- ErrorToStringHelper* error_tostring_helper() {
- return &error_tostring_helper_;
- }
-
Map* get_initial_js_array_map(ElementsKind kind,
Strength strength = Strength::WEAK);
@@ -1201,10 +1197,6 @@ class Isolate {
// the frame.
void RemoveMaterializedObjectsOnUnwind(StackFrame* frame);
- // Traverse prototype chain to find out whether the object is derived from
- // the Error object.
- bool IsErrorObject(Handle<Object> obj);
-
base::Atomic32 id_;
EntryStackItem* entry_stack_;
int stack_trace_nesting_level_;
@@ -1249,7 +1241,6 @@ class Isolate {
regexp_macro_assembler_canonicalize_;
RegExpStack* regexp_stack_;
DateCache* date_cache_;
- ErrorToStringHelper error_tostring_helper_;
unibrow::Mapping<unibrow::Ecma262Canonicalize> interp_canonicalize_mapping_;
CallInterfaceDescriptorData* call_descriptor_data_;
base::RandomNumberGenerator* random_number_generator_;
« no previous file with comments | « src/execution.cc ('k') | src/isolate.cc » ('j') | src/messages.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698