Source/WebKit/chromium/public/WebFrame.h - Issue 15071004: Plumb edit commands to plugins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/public/WebFrame.h

Issue 15071004: Plumb edit commands to plugins (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Alternative approach that gives plugin chance to override Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/WebKit/chromium/public/WebFrame.h

diff --git a/Source/WebKit/chromium/public/WebFrame.h b/Source/WebKit/chromium/public/WebFrame.h

index 948419fd51cf0b1705d6fc07e1c896d03538b40b..0e03eb1fb57c95424fac85fc2862e226e5347728 100644

--- a/Source/WebKit/chromium/public/WebFrame.h

+++ b/Source/WebKit/chromium/public/WebFrame.h

@@ -430,7 +430,7 @@ public:

// Unselect, etc. See EditorCommand.cpp for the full list of supported

// commands.

virtual bool executeCommand(const WebString&, const WebNode& = WebNode()) = 0;

- virtual bool executeCommand(const WebString&, const WebString& value) = 0;

+ virtual bool executeCommand(const WebString&, const WebString& value, const WebNode& = WebNode()) = 0;

virtual bool isCommandEnabled(const WebString&) const = 0;

// Spell-checking support.