Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: Source/WebKit/chromium/src/WebFrameImpl.cpp

Issue 15071004: Plumb edit commands to plugins (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Alternative approach that gives plugin chance to override Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/src/WebFrameImpl.cpp
diff --git a/Source/WebKit/chromium/src/WebFrameImpl.cpp b/Source/WebKit/chromium/src/WebFrameImpl.cpp
index 1965637215ec3f1e1ef8f6aadf7a0fb59debee03..7702715343d523c4fad2df561b89411b1595b5b1 100644
--- a/Source/WebKit/chromium/src/WebFrameImpl.cpp
+++ b/Source/WebKit/chromium/src/WebFrameImpl.cpp
@@ -1228,11 +1228,17 @@ bool WebFrameImpl::executeCommand(const WebString& name, const WebNode& node)
return result;
}
-bool WebFrameImpl::executeCommand(const WebString& name, const WebString& value)
+bool WebFrameImpl::executeCommand(const WebString& name, const WebString& value, const WebNode& node)
{
ASSERT(frame());
String webName = name;
+ WebPluginContainerImpl* pluginContainer = pluginContainerFromFrame(frame());
+ if (!pluginContainer)
+ pluginContainer = static_cast<WebPluginContainerImpl*>(node.pluginContainer());
abarth-chromium 2013/05/28 16:34:31 Should we have an inline helper function that impl
Fady Samuel 2013/05/29 04:40:06 Done.
+ if (pluginContainer && pluginContainer->executeEditCommand(name, value))
+ return true;
+
// moveToBeginningOfDocument and moveToEndfDocument are only handled by WebKit for editable nodes.
if (!frame()->editor()->canEdit() && webName == "moveToBeginningOfDocument")
return viewImpl()->propagateScroll(ScrollUp, ScrollByDocument);

Powered by Google App Engine
This is Rietveld 408576698