Plumb edit commands to plugins

Source/WebKit/chromium/src/WebPluginContainerImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 21 matching lines @@
 #include "WebPluginContainerImpl.h"
 
 #include "ChromeClientImpl.h"
 #include "ScrollbarGroup.h"
 #include "WebCursorInfo.h"
 #include "WebDataSourceImpl.h"
 #include "WebElement.h"
 #include "WebInputEvent.h"
 #include "WebInputEventConversion.h"
 #include "WebPlugin.h"
+#include "WebViewClient.h"
 #include "WebViewImpl.h"
 #include "core/page/Chrome.h"
 #include "core/page/EventHandler.h"
 #include "core/platform/chromium/ClipboardChromium.h"
 #include "core/platform/chromium/support/WrappedResourceResponse.h"
 
 #include "HTMLNames.h"
 #include "WebPrintParams.h"
 #include "bindings/v8/ScriptController.h"
 #include "core/dom/EventNames.h"
@@ skipping 289 matching lines @@
     if (m_webPlugin->executeEditCommand(name))
         return true;
 
     if (name != "copy")
         return false;
 
     copy();
     return true;
 }
 
+bool WebPluginContainerImpl::executeEditCommand(const WebString& name, const WebString& value)
+{
+    return m_webPlugin->executeEditCommand(name, value);
+}
+
 WebElement WebPluginContainerImpl::element()
 {
     return WebElement(m_element);
 }
 
 void WebPluginContainerImpl::invalidate()
 {
     Widget::invalidate();
 }
 
@@ skipping 382 matching lines @@
     const WebInputEvent* currentInputEvent = WebViewImpl::currentInputEvent();
 
     // Copy stashed info over, and only copy here in order not to interfere
     // the ctrl-c logic above.
     if (currentInputEvent
         && WebInputEvent::isKeyboardEventType(currentInputEvent->type)) {
         webEvent.modifiers |= currentInputEvent->modifiers &
             (WebInputEvent::CapsLockOn | WebInputEvent::NumLockOn);
     }
 
+    // Give the client a chance to issue edit comamnds.
+    WebViewImpl* view = WebViewImpl::fromPage(m_element->document()->frame()->page());

[abarth-chromium, 2013/05/28 16:34:31]

Do we know that frame() and page() return non-zero here?

[Fady Samuel, 2013/05/29 04:40:06]

I believe so, plugins are created only if they're attached (that may change in
the future). For now, this holds true.

+    if (m_webPlugin->supportsEditCommands() && view->client())
+        view->client()->handleCurrentKeyboardEvent();
+
     WebCursorInfo cursorInfo;
     if (m_webPlugin->handleInputEvent(webEvent, cursorInfo))
         event->setDefaultHandled();
 }
 
 void WebPluginContainerImpl::handleTouchEvent(TouchEvent* event)
 {
     switch (m_touchEventRequestType) {
     case TouchEventRequestTypeNone:
         return;
@@ skipping 96 matching lines @@
         // Take our element and get the clip rect from the enclosing layer and
         // frame view.
         clipRect.intersect(
             m_element->document()->view()->windowClipRectForFrameOwner(m_element, true));
     }
 
     return clipRect;
 }
 
 } // namespace WebKit