Adopt a less severe anti-starvation policy for immediate tasks

Adopt a less severe anti-starvation policy for immediate tasks

While addressing starvation of non-delayed tasks by delayed tasks is
important, the strict round robin was causing lots of existing layout
tests to flake. A less extreme anti-starvation policy is still
effective but doesn't entail fixing loads of tests.

BUG=567618, 67039, 560817, 567884
Committed: https://crrev.com/e4972a2857d0dc1b4653c752dfc2c7591430b888
Cr-Commit-Position: refs/heads/master@{#364106}

[alex clarke (OOO till 29th), 2015-12-08 13:56:00]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-08 13:56:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507093004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507093004/1

[alex clarke (OOO till 29th), 2015-12-08 13:56:17]

alexclarke@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[alex clarke (OOO till 29th), 2015-12-08 13:56:17]

PTAL :)

[commit-bot: I haz the power, 2015-12-08 13:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 13:58:15]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alex clarke (OOO till 29th), 2015-12-08 14:01:49]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-08 14:02:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507093004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507093004/20001

[commit-bot: I haz the power, 2015-12-08 14:27:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 14:27:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alex clarke (OOO till 29th), 2015-12-08 14:41:16]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-08 14:41:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507093004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507093004/20001

[commit-bot: I haz the power, 2015-12-08 14:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 14:53:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alex clarke (OOO till 29th), 2015-12-09 10:08:17]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 10:09:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507093004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507093004/20001

[alex clarke (OOO till 29th), 2015-12-09 10:28:35]

Description was changed from

==========
Adopt a less severe anti-starvation policy for immediate tasks

While addressing starvation of non-delayed tasks by delayed tasks is
important, the strict round robin was causing lots of existing layout
tests to flake. A less extreme anti-starvation policy is still
effective but doesn't entail fixing loads of tests.

BUG=567618, 67039, 560817
==========

to

==========
Adopt a less severe anti-starvation policy for immediate tasks

While addressing starvation of non-delayed tasks by delayed tasks is
important, the strict round robin was causing lots of existing layout
tests to flake. A less extreme anti-starvation policy is still
effective but doesn't entail fixing loads of tests.

BUG=567618, 67039, 560817, 567884
==========

[alex clarke (OOO till 29th), 2015-12-09 10:29:34]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 10:30:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507093004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507093004/40001

[rmcilroy, 2015-12-09 11:00:15]

LGTM

https://codereview.chromium.org/1507093004/diff/40001/components/scheduler/ba...
File components/scheduler/base/task_queue_selector.h (right):

https://codereview.chromium.org/1507093004/diff/40001/components/scheduler/ba...
components/scheduler/base/task_queue_selector.h:77: // queue.  This method will
force select an imemdiate task if those are being
/imemdiate/immediate

[commit-bot: I haz the power, 2015-12-09 11:06:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 11:06:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alex clarke (OOO till 29th), 2015-12-09 11:21:29]

Thanks!

https://codereview.chromium.org/1507093004/diff/40001/components/scheduler/ba...
File components/scheduler/base/task_queue_selector.h (right):

https://codereview.chromium.org/1507093004/diff/40001/components/scheduler/ba...
components/scheduler/base/task_queue_selector.h:77: // queue.  This method will
force select an imemdiate task if those are being
On 2015/12/09 11:00:15, rmcilroy wrote:
> /imemdiate/immediate

Done.

[alex clarke (OOO till 29th), 2015-12-09 11:21:33]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2015-12-09 11:21:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1507093004/#ps60001
(title: "Fix comment nit plus a couple of tests")

[commit-bot: I haz the power, 2015-12-09 11:22:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507093004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507093004/60001

[commit-bot: I haz the power, 2015-12-09 13:00:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 13:00:04]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[alex clarke (OOO till 29th), 2015-12-09 15:47:22]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2015-12-09 15:47:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1507093004/#ps80001
(title: "Fix test flakes")

[commit-bot: I haz the power, 2015-12-09 15:48:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1507093004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1507093004/80001

[commit-bot: I haz the power, 2015-12-09 18:16:46]

Description was changed from

==========
Adopt a less severe anti-starvation policy for immediate tasks

While addressing starvation of non-delayed tasks by delayed tasks is
important, the strict round robin was causing lots of existing layout
tests to flake. A less extreme anti-starvation policy is still
effective but doesn't entail fixing loads of tests.

BUG=567618, 67039, 560817, 567884
==========

to

==========
Adopt a less severe anti-starvation policy for immediate tasks

While addressing starvation of non-delayed tasks by delayed tasks is
important, the strict round robin was causing lots of existing layout
tests to flake. A less extreme anti-starvation policy is still
effective but doesn't entail fixing loads of tests.

BUG=567618, 67039, 560817, 567884
==========

[commit-bot: I haz the power, 2015-12-09 18:16:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-09 18:17:23]

Description was changed from

==========
Adopt a less severe anti-starvation policy for immediate tasks

While addressing starvation of non-delayed tasks by delayed tasks is
important, the strict round robin was causing lots of existing layout
tests to flake. A less extreme anti-starvation policy is still
effective but doesn't entail fixing loads of tests.

BUG=567618, 67039, 560817, 567884
==========

to

==========
Adopt a less severe anti-starvation policy for immediate tasks

While addressing starvation of non-delayed tasks by delayed tasks is
important, the strict round robin was causing lots of existing layout
tests to flake. A less extreme anti-starvation policy is still
effective but doesn't entail fixing loads of tests.

BUG=567618, 67039, 560817, 567884

Committed: https://crrev.com/e4972a2857d0dc1b4653c752dfc2c7591430b888
Cr-Commit-Position: refs/heads/master@{#364106}
==========

[commit-bot: I haz the power, 2015-12-09 18:17:24]

Patchset 5 (id:??) landed as
https://crrev.com/e4972a2857d0dc1b4653c752dfc2c7591430b888
Cr-Commit-Position: refs/heads/master@{#364106}