Adopt a less severe anti-starvation policy for immediate tasks

components/scheduler/base/task_queue_selector.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SCHEDULER_BASE_TASK_QUEUE_SELECTOR_H_
 #define COMPONENTS_SCHEDULER_BASE_TASK_QUEUE_SELECTOR_H_
 
 #include <set>
 
 #include "base/compiler_specific.h"
@@ skipping 54 matching lines @@
     return &immediate_work_queue_sets_;
   }
 
   // Returns true if all the enabled work queues are empty. Returns false
   // otherwise.
   bool EnabledWorkQueuesEmpty() const;
 
  protected:
   // Return true if |out_queue| contains the queue with the oldest pending task
   // from the set of queues of |priority|, or false if all queues of that
-  // priority are empty.
+  // priority are empty. In addition |out_chose_delayed_over_immediate| is set
+  // to true iff we chose a delayed work queue in favour of an immediate work
+  // queue.  This method will force select an imemdiate task if those are being

[rmcilroy, 2015/12/09 11:00:15]

/imemdiate/immediate

[alex clarke (OOO till 29th), 2015/12/09 11:21:28]

Done.

+  // starved by delayed tasks.
   bool ChooseOldestWithPriority(TaskQueue::QueuePriority priority,
+                                bool* out_chose_delayed_over_immediate,
                                 WorkQueue** out_work_queue) const;
 
-  void SetForceSelectImmediateForTest(bool force_select_immediate);
+  void SetImmediateStarvationCountForTest(size_t immediate_starvation_count);
 
  private:
   // Returns the priority which is next after |priority|.
   static TaskQueue::QueuePriority NextPriority(
       TaskQueue::QueuePriority priority);
 
   bool ChooseOldestImmediateTaskWithPriority(TaskQueue::QueuePriority priority,
                                              WorkQueue** out_work_queue) const;
 
   bool ChooseOldestDelayedTaskWithPriority(TaskQueue::QueuePriority priority,
                                            WorkQueue** out_work_queue) const;
 
+  // Return true if |out_queue| contains the queue with the oldest pending task
+  // from the set of queues of |priority|, or false if all queues of that
+  // priority are empty. In addition |out_chose_delayed_over_immediate| is set
+  // to true iff we chose a delayed work queue in favour of an immediate work
+  // queue.
   bool ChooseOldestImmediateOrDelayedTaskWithPriority(
       TaskQueue::QueuePriority priority,
+      bool* out_chose_delayed_over_immediate,
       WorkQueue** out_work_queue) const;
 
   // Called whenever the selector chooses a task queue for execution with the
   // priority |priority|.
-  void DidSelectQueueWithPriority(TaskQueue::QueuePriority priority);
+  void DidSelectQueueWithPriority(TaskQueue::QueuePriority priority,
+                                  bool chose_delayed_over_immediate);
 
   // Number of high priority tasks which can be run before a normal priority
   // task should be selected to prevent starvation.
   // TODO(rmcilroy): Check if this is a good value.
-  static const size_t kMaxStarvationTasks = 5;
+  static const size_t kMaxHighPriorityStarvationTasks = 5;
+
+  // Maximum number of delayed tasks tasks which can be run while there's a
+  // waiting non-delayed task.
+  static const size_t kMaxDelayedStarvationTasks = 3;
 
  private:
   base::ThreadChecker main_thread_checker_;
   WorkQueueSets delayed_work_queue_sets_;
   WorkQueueSets immediate_work_queue_sets_;
-  bool force_select_immediate_;
-
-  size_t starvation_count_;
+  size_t immediate_starvation_count_;
+  size_t high_priority_starvation_count_;
   Observer* task_queue_selector_observer_;  // NOT OWNED
   DISALLOW_COPY_AND_ASSIGN(TaskQueueSelector);
 };
 
 }  // namespace internal
 }  // namespace scheduler
 
 #endif  // COMPONENTS_SCHEDULER_BASE_TASK_QUEUE_SELECTOR_H