[nacltoons] Add compound shapes.

[nacltoons] Add compound shapes.

This change is suprisingly large as it involves switching 
from CCPhysicsSprite (where each physics object must have
a visisble sprite) to CCPhysicsNode (where the physics
node itself is not visible, but can have zero or more
visible children).

This means that a single phyiscs node (corresponding to a
single box2d body) can be constructed from many shapes and
sprites, each adding its own fixtures to the overall body.

R=binji@chromium.org

Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1552

[binji, 2013-05-10 16:59:01]

lgtm

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
File nacltoons/data/res/drawing.lua (right):

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
nacltoons/data/res/drawing.lua:38: -- Constants for tagging cococs nodes
sp: cocos

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
nacltoons/data/res/drawing.lua:39: local TAG_BATCH_NODE = 0x1
Isn't this tag already used? Not sure where but it seems likely.

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
nacltoons/data/res/drawing.lua:159: --if absolute then
remove

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
nacltoons/data/res/drawing.lua:281: -- Add visiable sprite
sp: visible

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
nacltoons/data/res/drawing.lua:296: -- Create the initial (invidible) node at
the center
sp: invisible

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
nacltoons/data/res/drawing.lua:335: fixture = AddLineToShape(sprite, from, to,
color, true)
might be clearer to use a string or constant here (rather than true)

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/editor.lua
File nacltoons/data/res/editor.lua (right):

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/editor....
nacltoons/data/res/editor.lua:83: x = self.node:getPositionX()
does this do anything?

[Sam Clegg, 2013-05-15 20:18:43]

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
File nacltoons/data/res/drawing.lua (right):

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
nacltoons/data/res/drawing.lua:38: -- Constants for tagging cococs nodes
On 2013/05/10 16:59:01, binji wrote:
> sp: cocos

Done.

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
nacltoons/data/res/drawing.lua:159: --if absolute then
On 2013/05/10 16:59:01, binji wrote:
> remove

Done.

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
nacltoons/data/res/drawing.lua:281: -- Add visiable sprite
On 2013/05/10 16:59:01, binji wrote:
> sp: visible

Done.

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
nacltoons/data/res/drawing.lua:296: -- Create the initial (invidible) node at
the center
On 2013/05/10 16:59:01, binji wrote:
> sp: invisible

Done.

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/editor.lua
File nacltoons/data/res/editor.lua (right):

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/editor....
nacltoons/data/res/editor.lua:83: x = self.node:getPositionX()
On 2013/05/10 16:59:01, binji wrote:
> does this do anything?

Done.

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/editor....
nacltoons/data/res/editor.lua:83: x = self.node:getPositionX()
On 2013/05/10 16:59:01, binji wrote:
> does this do anything?

Done.

[Sam Clegg, 2013-05-20 23:54:13]

Unified "sprites" and "shapes" in the level def files.
Sprites are just shapes, or sub-shapes of type "image".
PTAL.

[binji, 2013-05-21 21:11:36]

slgtm, though I think drawing.lua could use some cleanup.

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
File nacltoons/data/res/drawing.lua (right):

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
nacltoons/data/res/drawing.lua:281: -- Add visiable sprite
On 2013/05/15 20:18:43, Sam Clegg wrote:
> On 2013/05/10 16:59:01, binji wrote:
> > sp: visible
> 
> Done.

or is it...?

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
File nacltoons/data/res/drawing.lua (right):

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
nacltoons/data/res/drawing.lua:61: local node =
CCSpriteBatchNode:createWithTexture(brush_tex, 100)
what is 100?

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
nacltoons/data/res/drawing.lua:125: sphere.m_p.x =
util.ScreenToWorld(location.x) - body:GetPosition().x
AddSpriteToShape below uses world_pos for location, but this function is
converting from screen to world?

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
nacltoons/data/res/drawing.lua:198: --- Create a physics sprite at a fiven
location with a given image
sp: given

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
nacltoons/data/res/drawing.lua:200: local pos =
util.PointFromLua(sprite_def.pos, not absolute)
you should probably flip PointFromLua to use absolute, not relative.

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
nacltoons/data/res/drawing.lua:207: if absolute then
I expected to see more symmetry between this function and AddLineToShape, w.r.t.
calculating locations.

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
nacltoons/data/res/drawing.lua:251: child = AddChildShape(shape, child_def,
false)
I'm finding the usage of absolute vs. not quite confusing. It may be because it
is not clear which functions require what, and that the same parameter can be
used for node space or world space. Is there a way to make this more
understandable?

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/valida...
File nacltoons/data/res/validate.lua (right):

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/valida...
nacltoons/data/res/validate.lua:137: end
warn on no match? or do you do this to allow globbing?

[Sam Clegg, 2013-05-21 22:51:45]

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
File nacltoons/data/res/drawing.lua (right):

https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
nacltoons/data/res/drawing.lua:281: -- Add visiable sprite
On 2013/05/21 21:11:36, binji wrote:
> On 2013/05/15 20:18:43, Sam Clegg wrote:
> > On 2013/05/10 16:59:01, binji wrote:
> > > sp: visible
> > 
> > Done.
> 
> or is it...?

Done.

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
File nacltoons/data/res/drawing.lua (right):

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
nacltoons/data/res/drawing.lua:61: local node =
CCSpriteBatchNode:createWithTexture(brush_tex, 100)
On 2013/05/21 21:11:36, binji wrote:
> what is 100?

Its the initial size of the batch node.

Done.

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
nacltoons/data/res/drawing.lua:198: --- Create a physics sprite at a fiven
location with a given image
On 2013/05/21 21:11:36, binji wrote:
> sp: given

Done.

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
nacltoons/data/res/drawing.lua:200: local pos =
util.PointFromLua(sprite_def.pos, not absolute)
On 2013/05/21 21:11:36, binji wrote:
> you should probably flip PointFromLua to use absolute, not relative.

Done.

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
nacltoons/data/res/drawing.lua:207: if absolute then
On 2013/05/21 21:11:36, binji wrote:
> I expected to see more symmetry between this function and AddLineToShape,
w.r.t.
> calculating locations.

Yes, me too.  Its a little confusing but the box2d method
SetAsBox on b2PolygonShapeseems to body-relative 
coordinates, where as setting the m_p of a b2CircleShape 
expects world space.  Well noticed.

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
nacltoons/data/res/drawing.lua:251: child = AddChildShape(shape, child_def,
false)
On 2013/05/21 21:11:36, binji wrote:
> I'm finding the usage of absolute vs. not quite confusing. It may be because
it
> is not clear which functions require what, and that the same parameter can be
> used for node space or world space. Is there a way to make this more
> understandable?

I agree.  I'll see what I can do.  

I made the aforementioned logic inversion on PointFromLua which makes it a
little clearer.

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/valida...
File nacltoons/data/res/validate.lua (right):

https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/valida...
nacltoons/data/res/validate.lua:137: end
On 2013/05/21 21:11:36, binji wrote:
> warn on no match? or do you do this to allow globbing?

The problem is that thee is no way to do "if __name__ == '__main__' in lua"  so
any lua executable at imports this
file will have this block executed.  Annoying.

[Sam Clegg, 2013-05-21 23:08:23]

On 2013/05/21 22:51:45, Sam Clegg wrote:
>
https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
> File nacltoons/data/res/drawing.lua (right):
> 
>
https://codereview.chromium.org/15070003/diff/4004/nacltoons/data/res/drawing...
> nacltoons/data/res/drawing.lua:281: -- Add visiable sprite
> On 2013/05/21 21:11:36, binji wrote:
> > On 2013/05/15 20:18:43, Sam Clegg wrote:
> > > On 2013/05/10 16:59:01, binji wrote:
> > > > sp: visible
> > > 
> > > Done.
> > 
> > or is it...?
> 
> Done.
> 
>
https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
> File nacltoons/data/res/drawing.lua (right):
> 
>
https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
> nacltoons/data/res/drawing.lua:61: local node =
> CCSpriteBatchNode:createWithTexture(brush_tex, 100)
> On 2013/05/21 21:11:36, binji wrote:
> > what is 100?
> 
> Its the initial size of the batch node.
> 
> Done.
> 
>
https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
> nacltoons/data/res/drawing.lua:198: --- Create a physics sprite at a fiven
> location with a given image
> On 2013/05/21 21:11:36, binji wrote:
> > sp: given
> 
> Done.
> 
>
https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
> nacltoons/data/res/drawing.lua:200: local pos =
> util.PointFromLua(sprite_def.pos, not absolute)
> On 2013/05/21 21:11:36, binji wrote:
> > you should probably flip PointFromLua to use absolute, not relative.
> 
> Done.
> 
>
https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
> nacltoons/data/res/drawing.lua:207: if absolute then
> On 2013/05/21 21:11:36, binji wrote:
> > I expected to see more symmetry between this function and AddLineToShape,
> w.r.t.
> > calculating locations.
> 
> Yes, me too.  Its a little confusing but the box2d method
> SetAsBox on b2PolygonShapeseems to body-relative 
> coordinates, where as setting the m_p of a b2CircleShape 
> expects world space.  Well noticed.
> 
>
https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/drawin...
> nacltoons/data/res/drawing.lua:251: child = AddChildShape(shape, child_def,
> false)
> On 2013/05/21 21:11:36, binji wrote:
> > I'm finding the usage of absolute vs. not quite confusing. It may be because
> it
> > is not clear which functions require what, and that the same parameter can
be
> > used for node space or world space. Is there a way to make this more
> > understandable?
> 
> I agree.  I'll see what I can do.  
> 
> I made the aforementioned logic inversion on PointFromLua which makes it a
> little clearer.
> 
>
https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/valida...
> File nacltoons/data/res/validate.lua (right):
> 
>
https://codereview.chromium.org/15070003/diff/30001/nacltoons/data/res/valida...
> nacltoons/data/res/validate.lua:137: end
> On 2013/05/21 21:11:36, binji wrote:
> > warn on no match? or do you do this to allow globbing?
> 
> The problem is that thee is no way to do "if __name__ == '__main__' in lua" 
so
> any lua executable at imports this
> file will have this block executed.  Annoying.

I found a (slightly) better way to do this :)

[Sam Clegg, 2013-05-21 23:15:59]

Committed patchset #7 manually as r1552 (presubmit successful).