Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: test/cctest/test-inobject-slack-tracking.cc

Issue 1506753002: [test] Test expectations in cctest should use CHECK and not DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/cctest/test-liveedit.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-inobject-slack-tracking.cc
diff --git a/test/cctest/test-inobject-slack-tracking.cc b/test/cctest/test-inobject-slack-tracking.cc
index 79cb8335adbf6e1836541c8da3cc12c4ca506b6e..5fdebb124ed9249d97fab6617a95006025cb22e1 100644
--- a/test/cctest/test-inobject-slack-tracking.cc
+++ b/test/cctest/test-inobject-slack-tracking.cc
@@ -99,7 +99,7 @@ static double GetDoubleFieldValue(JSObject* obj, FieldIndex field_index) {
return obj->RawFastDoublePropertyAt(field_index);
} else {
Object* value = obj->RawFastPropertyAt(field_index);
- DCHECK(value->IsMutableHeapNumber());
+ CHECK(value->IsMutableHeapNumber());
return HeapNumber::cast(value)->value();
}
}
@@ -578,7 +578,7 @@ static void TestClassHierarchy(const std::vector<int>& hierarchy_desc, int n) {
fields_count += fields_count_at_current_level;
// This test is not suitable for in-object properties count overflow case.
- DCHECK_LT(fields_count, kMaxInobjectProperties);
+ CHECK_LT(fields_count, kMaxInobjectProperties);
// Create |class_name| objects and check slack tracking.
v8::Local<v8::Script> new_script = GetNewObjectScript(class_name);
« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/cctest/test-liveedit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698