Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: src/IceTargetLoweringMIPS32.h

Issue 1506653002: Subzero: Add Non-SFI support for x86-32. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fill in part of the lit test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLoweringMIPS32.h
diff --git a/src/IceTargetLoweringMIPS32.h b/src/IceTargetLoweringMIPS32.h
index 60c62dd105d3dba053a96266c8a039dc965795cc..c4565d7dc3fd7875da9f1b7e25e9f14fdcf41c2c 100644
--- a/src/IceTargetLoweringMIPS32.h
+++ b/src/IceTargetLoweringMIPS32.h
@@ -29,7 +29,7 @@ class TargetMIPS32 : public TargetLowering {
TargetMIPS32 &operator=(const TargetMIPS32 &) = delete;
public:
- static void staticInit();
+ static void staticInit(const ClFlags &Flags);
// TODO(jvoung): return a unique_ptr.
static TargetMIPS32 *create(Cfg *Func) { return new TargetMIPS32(Func); }
@@ -90,11 +90,6 @@ public:
void emitVariable(const Variable *Var) const override;
- const char *getConstantPrefix() const final { return ""; }
- void emit(const ConstantUndef *C) const final {
- (void)C;
- llvm::report_fatal_error("Not yet implemented");
- }
void emit(const ConstantInteger32 *C) const final {
(void)C;
llvm::report_fatal_error("Not yet implemented");
@@ -111,6 +106,14 @@ public:
(void)C;
llvm::report_fatal_error("Not yet implemented");
}
+ void emit(const ConstantUndef *C) const final {
+ (void)C;
+ llvm::report_fatal_error("Not yet implemented");
+ }
+ void emit(const ConstantRelocatable *C) const final {
+ (void)C;
+ llvm::report_fatal_error("Not yet implemented");
+ }
// The following are helpers that insert lowered MIPS32 instructions with
// minimal syntactic overhead, so that the lowering code can look as close to
@@ -184,10 +187,10 @@ public:
Legal_Reg = 1 << 0, // physical register, not stack location
Legal_Imm = 1 << 1,
Legal_Mem = 1 << 2,
- Legal_All = ~Legal_None
+ Legal_Default = ~Legal_None
};
typedef uint32_t LegalMask;
- Operand *legalize(Operand *From, LegalMask Allowed = Legal_All,
+ Operand *legalize(Operand *From, LegalMask Allowed = Legal_Default,
int32_t RegNum = Variable::NoRegister);
Variable *legalizeToVar(Operand *From, int32_t RegNum = Variable::NoRegister);

Powered by Google App Engine
This is Rietveld 408576698