Issue 150653007: Remove code allowing implicit conversion from WebElementCollection to WebNodeList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150653007: Remove code allowing implicit conversion from WebElementCollection to WebNodeList. (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
tkent, dglazkov

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove code allowing implicit conversion from WebElementCollection to WebNodeList. Remove code allowing implicit conversion from WebElementCollection to WebNodeList. This workaround was added in r166263 when getElementByTagName() was updated to return a WebElementCollection instead of a WebNodeList. However, since then, the callers have been updated on Chromium side and this workaround code is no longer needed. R=tkent BUG=235008 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166719

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -41 lines)			Patch
M	Source/web/WebNodeList.cpp	View	1 chunk	+1 line, -34 lines	0 comments	Download
M	public/web/WebElementCollection.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	public/web/WebNodeList.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/150653007/1

6 years, 10 months ago (2014-02-07 16:00:00 UTC) #4

Message was sent while issue was closed.

Change committed as 166719

Expand Messages | Collapse Messages