Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Side by Side Diff: public/web/WebNodeList.h

Issue 150653007: Remove code allowing implicit conversion from WebElementCollection to WebNodeList. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « public/web/WebElementCollection.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 14 matching lines...) Expand all
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef WebNodeList_h 31 #ifndef WebNodeList_h
32 #define WebNodeList_h 32 #define WebNodeList_h
33 33
34 #include "../platform/WebCommon.h" 34 #include "../platform/WebCommon.h"
35 #include "WebElementCollection.h"
36 35
37 namespace WebCore { class NodeList; } 36 namespace WebCore { class NodeList; }
38 #if BLINK_IMPLEMENTATION 37 #if BLINK_IMPLEMENTATION
39 namespace WTF { template <typename T> class PassRefPtr; } 38 namespace WTF { template <typename T> class PassRefPtr; }
40 #endif 39 #endif
41 40
42 namespace blink { 41 namespace blink {
43 class WebNode; 42 class WebNode;
44 43
45 // Provides readonly access to some properties of a DOM node. 44 // Provides readonly access to some properties of a DOM node.
46 class WebNodeList { 45 class WebNodeList {
47 public: 46 public:
48 ~WebNodeList() { reset(); } 47 ~WebNodeList() { reset(); }
49 48
50 WebNodeList() : m_private(0) { } 49 WebNodeList() : m_private(0) { }
51 WebNodeList(const WebNodeList& n) : m_private(0) { assign(n); } 50 WebNodeList(const WebNodeList& n) : m_private(0) { assign(n); }
52 WebNodeList& operator=(const WebNodeList& n) 51 WebNodeList& operator=(const WebNodeList& n)
53 { 52 {
54 assign(n); 53 assign(n);
55 return *this; 54 return *this;
56 } 55 }
57 56
58 // FIXME(crbug.com/235008): Remove once chromium has been updated to stop us ing
59 // WebElementCollection as a WebNodeList.
60 BLINK_EXPORT WebNodeList(const WebElementCollection&);
61
62 BLINK_EXPORT void reset(); 57 BLINK_EXPORT void reset();
63 BLINK_EXPORT void assign(const WebNodeList&); 58 BLINK_EXPORT void assign(const WebNodeList&);
64 59
65 BLINK_EXPORT unsigned length() const; 60 BLINK_EXPORT unsigned length() const;
66 BLINK_EXPORT WebNode item(size_t) const; 61 BLINK_EXPORT WebNode item(size_t) const;
67 62
68 #if BLINK_IMPLEMENTATION 63 #if BLINK_IMPLEMENTATION
69 WebNodeList(const WTF::PassRefPtr<WebCore::NodeList>&); 64 WebNodeList(const WTF::PassRefPtr<WebCore::NodeList>&);
70 #endif 65 #endif
71 66
72 private: 67 private:
73 void assign(WebCore::NodeList*); 68 void assign(WebCore::NodeList*);
74 WebCore::NodeList* m_private; 69 WebCore::NodeList* m_private;
75 }; 70 };
76 71
77 } // namespace blink 72 } // namespace blink
78 73
79 #endif 74 #endif
OLDNEW
« no previous file with comments | « public/web/WebElementCollection.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698