Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 150653006: Remove the Vector::append overload that takes a Vector (Closed)

Created:
6 years, 10 months ago by gnana
Modified:
6 years, 10 months ago
CC:
blink-reviews, eae+blinkwatch, fs, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, aandrey+blink_chromium.org, rune+blink, jamesr, krit, aboxhall, bemjb+rendering_chromium.org, dsinclair, yurys+blink_chromium.org, abarth-chromium, danakj, dglazkov+blink, Rik, jchaffraix+rendering, pdr., rwlbuis, Inactive, mstensho+blink_opera.com, loislo+blink_chromium.org, zoltan1, sof, jbroman, Raymond Toy, kinuko, dmazzoni, gyuyoung.kim_webkit.org, darktears, leviw+renderwatch, blink-layers+watch_chromium.org, ed+blinkwatch_opera.com, f(malita), groby+blinkspell_chromium.org, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove the Vector::append overload that takes a Vector Use Vector::appendVector instead. This is based on webkit CL http://trac.webkit.org/changeset/149579 BUG=NONE Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167458

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -49 lines) Patch
M Source/core/accessibility/AXARIAGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/MatchedPropertiesCache.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentStyleSheetCollector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/StyleEngine.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/StyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextCheckingHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FormController.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLFormattingElementList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGlyphMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathByteStream.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/Performance.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/timing/PerformanceUserTiming.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathNodeSet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/FileChooser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/SharedBufferChunkReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/ThreadSafeDataTransport.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/network/FormDataBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/transforms/TransformOperations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Vector.h View 1 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
gnana
Please have a look
6 years, 10 months ago (2014-02-07 12:13:27 UTC) #1
abarth-chromium
I'm not the right person to review this CL. You want some one knowledgeable in ...
6 years, 10 months ago (2014-02-07 18:45:59 UTC) #2
abarth-chromium
I'd "git log" the WTF directory and see who's been reviewing other C++11-ish changes.
6 years, 10 months ago (2014-02-07 18:46:27 UTC) #3
gnana
Please have a look.
6 years, 10 months ago (2014-02-11 07:50:10 UTC) #4
Nico
I'm not sure about the c++11 bits (clang bots build with -std=c++11 and they build ...
6 years, 10 months ago (2014-02-18 20:26:02 UTC) #5
gnana
The CQ bit was checked by gnanasekar.s@samsung.com
6 years, 10 months ago (2014-02-19 11:27:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/150653006/280001
6 years, 10 months ago (2014-02-19 11:27:37 UTC) #7
gnana
The CQ bit was unchecked by gnanasekar.s@samsung.com
6 years, 10 months ago (2014-02-19 11:45:36 UTC) #8
gnana
** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: Source/modules/webaudio/AudioContext.cpp +eseidel for ...
6 years, 10 months ago (2014-02-19 12:00:45 UTC) #9
gnana
** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: Source/modules/webaudio/AudioContext.cpp +eseidel for ...
6 years, 10 months ago (2014-02-19 12:01:14 UTC) #10
abarth-chromium
AudioContext LGTM
6 years, 10 months ago (2014-02-19 15:49:08 UTC) #11
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 10 months ago (2014-02-19 15:49:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/150653006/280001
6 years, 10 months ago (2014-02-19 21:54:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/150653006/280001
6 years, 10 months ago (2014-02-19 22:59:53 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 07:03:30 UTC) #15
Message was sent while issue was closed. 
Change committed as 167458

Powered by Google App Engine
This is Rietveld 408576698