chrome/browser/ui/webui/options/manage_profile_handler.cc - Issue 1506353007: Show warning message when trying to create SU with existing name

Unified Diff: chrome/browser/ui/webui/options/manage_profile_handler.cc

Issue 1506353007: Show warning message when trying to create SU with existing name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed break from the nameIsUnique loop Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/options/manage_profile_handler.cc

diff --git a/chrome/browser/ui/webui/options/manage_profile_handler.cc b/chrome/browser/ui/webui/options/manage_profile_handler.cc

index 43e5f87aff42e2bb075ecaab2cac76c6e72799cc..7ee405830c25ab29605ea8e69d5091e5b9c5ea25 100644

--- a/chrome/browser/ui/webui/options/manage_profile_handler.cc

+++ b/chrome/browser/ui/webui/options/manage_profile_handler.cc

@@ -92,6 +92,8 @@ void ManageProfileHandler::GetLocalizedValues(

{ "manageProfilesIconLabel", IDS_PROFILES_MANAGE_ICON_LABEL },

{ "manageProfilesExistingSupervisedUser",

IDS_PROFILES_CREATE_EXISTING_LEGACY_SUPERVISED_USER_ERROR },

+ { "managedProfilesExistingLocalSupervisedUser",

+ IDS_PROFILES_CREATE_EXISTING_LEGACY_SUPERVISED_USER_ERROR_EXISTS_LOCALLY },

Marc Treib 2015/12/10 11:36:41 nit: "exist" is in there twice; can we remove one

Pam (message me for reviews) 2015/12/15 14:31:37 Or a new string with a more suitable tone but stil

atanasova 2015/12/15 17:57:36 The second type of string is useful since it conta

{ "manageProfilesSupervisedSignedInLabel",

IDS_PROFILES_CREATE_SUPERVISED_SIGNED_IN_LABEL },

{ "manageProfilesSupervisedNotSignedIn",

« chrome/browser/resources/options/manage_profile_overlay.js ('K') | « chrome/browser/resources/options/manage_profile_overlay.js ('k') | no next file » | no next file with comments »