Show warning message when trying to create SU with existing name

chrome/browser/ui/webui/options/manage_profile_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/manage_profile_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
@@ skipping 74 matching lines @@
 
 void ManageProfileHandler::GetLocalizedValues(
     base::DictionaryValue* localized_strings) {
   DCHECK(localized_strings);
 
   static OptionsStringResource resources[] = {
     { "manageProfilesNameLabel", IDS_PROFILES_MANAGE_NAME_LABEL },
     { "manageProfilesIconLabel", IDS_PROFILES_MANAGE_ICON_LABEL },
     { "manageProfilesExistingSupervisedUser",
         IDS_PROFILES_CREATE_EXISTING_LEGACY_SUPERVISED_USER_ERROR },
+    { "managedProfilesExistingLocalSupervisedUser",
+        IDS_PROFILES_CREATE_EXISTING_LEGACY_SUPERVISED_USER_ERROR_EXISTS_LOCALLY },

[Marc Treib, 2015/12/10 11:36:41]

nit: "exist" is in there twice; can we remove one and avoid the overlong line?
:)
e.g.
IDS_PROFILES_CREATE_LEGACY_SUPERVISED_USER_ERROR_EXISTS_LOCALLY
and then also rename the other message to
IDS_PROFILES_CREATE_LEGACY_SUPERVISED_USER_ERROR_EXISTS_REMOTELY
to make the difference clear.

(Or ignore all this if we decide to reuse the CrOS string...)

[Pam (message me for reviews), 2015/12/15 14:31:37]

Or a new string with a more suitable tone but still covering both cases.

[atanasova, 2015/12/15 17:57:36]

The second type of string is useful since it contains a link to the import
option.

     { "manageProfilesSupervisedSignedInLabel",
         IDS_PROFILES_CREATE_SUPERVISED_SIGNED_IN_LABEL },
     { "manageProfilesSupervisedNotSignedIn",
         IDS_PROFILES_CREATE_SUPERVISED_NOT_SIGNED_IN_HTML },
     { "manageProfilesSupervisedAccountDetailsOutOfDate",
         IDS_PROFILES_CREATE_SUPERVISED_ACCOUNT_DETAILS_OUT_OF_DATE_LABEL },
     { "manageProfilesSupervisedSignInAgainLink",
         IDS_PROFILES_GAIA_REAUTH_TITLE },
     { "manageProfilesConfirm", IDS_SAVE },
     { "deleteProfileTitle", IDS_PROFILES_DELETE_TITLE },
@@ skipping 460 matching lines @@
 
   // Update the UI buttons.
   OnHasProfileShortcuts(false);
 }
 
 void ManageProfileHandler::RefreshGaiaPicture(const base::ListValue* args) {
   profiles::UpdateGaiaProfileInfoIfNeeded(Profile::FromWebUI(web_ui()));
 }
 
 }  // namespace options