Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1506323002: Explicitly specify that FilePath is not just absolute, but also a normalized path. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Explicitly specify that FilePath is not just absolute, but also a normalized path. It was implied, and every client I know of uses absolute and normalized paths. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1f5973e24e6b4869813ba88513e718c9597d1e57

Patch Set 1 #

Patch Set 2 : Add an error for invalid file paths. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -6 lines) Patch
M pkg/analysis_server/doc/api.html View 1 3 chunks +13 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 1 4 chunks +10 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/RequestErrorCode.java View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
5 years ago (2015-12-09 02:48:17 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-09 14:56:28 UTC) #2
scheglov
PTAL I've added a new error for invalid format of file paths.
5 years ago (2015-12-09 16:39:25 UTC) #3
Brian Wilkerson
LGTM
5 years ago (2015-12-09 18:41:20 UTC) #4
scheglov
5 years ago (2015-12-09 19:31:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1f5973e24e6b4869813ba88513e718c9597d1e57 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698