pkg/analysis_server/test/integration/protocol_matchers.dart - Issue 1506323002: Explicitly specify that FilePath is not just absolute, but also a normalized path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/integration/protocol_matchers.dart

Issue 1506323002: Explicitly specify that FilePath is not just absolute, but also a normalized path. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add an error for invalid file paths. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | pkg/analysis_server/tool/spec/generated/java/types/RequestErrorCode.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/integration/protocol_matchers.dart

diff --git a/pkg/analysis_server/test/integration/protocol_matchers.dart b/pkg/analysis_server/test/integration/protocol_matchers.dart

index 2a0cd06185534ec25acc6dd21071ca3dffc25dd2..37fb38e4884b1d1635929548fab5dd047d322791 100644

--- a/pkg/analysis_server/test/integration/protocol_matchers.dart

+++ b/pkg/analysis_server/test/integration/protocol_matchers.dart

@@ -2104,6 +2104,7 @@ final Matcher isRequestError = new LazyMatcher(() => new MatchesJsonObject(

* GET_REACHABLE_SOURCES_INVALID_FILE

* INVALID_ANALYSIS_ROOT

* INVALID_EXECUTION_CONTEXT

+ * INVALID_FILE_PATH_FORMAT

* INVALID_OVERLAY_CHANGE

* INVALID_PARAMETER

* INVALID_REQUEST

@@ -2130,6 +2131,7 @@ final Matcher isRequestErrorCode = new MatchesEnum("RequestErrorCode", [

"GET_REACHABLE_SOURCES_INVALID_FILE",

"INVALID_ANALYSIS_ROOT",

"INVALID_EXECUTION_CONTEXT",

+ "INVALID_FILE_PATH_FORMAT",

"INVALID_OVERLAY_CHANGE",

"INVALID_PARAMETER",

"INVALID_REQUEST",