Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1506203002: Move texture drawing utility method to SkGpuDevice (Closed)

Created:
5 years ago by jvanverth1
Modified:
5 years ago
Reviewers:
*bsalomon, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move texture drawing utility method to SkGpuDevice BUG=skia:4542 Committed: https://skia.googlesource.com/skia/+/0671b967eb02d44c8951dc4dc39df09fac15b097

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M include/gpu/GrContext.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M samplecode/SampleAnimatedText.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrTest.cpp View 2 chunks +14 lines, -14 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
jvanverth1
5 years ago (2015-12-08 19:45:58 UTC) #2
robertphillips
lgtm - does this actually buy us anything? https://codereview.chromium.org/1506203002/diff/1/include/gpu/GrContext.h File include/gpu/GrContext.h (right): https://codereview.chromium.org/1506203002/diff/1/include/gpu/GrContext.h#newcode356 include/gpu/GrContext.h:356: update ...
5 years ago (2015-12-08 19:49:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506203002/20001
5 years ago (2015-12-08 19:52:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/4507)
5 years ago (2015-12-08 19:57:43 UTC) #8
jvanverth1
Adding Brian for API approval
5 years ago (2015-12-08 20:07:55 UTC) #11
bsalomon
lgtm
5 years ago (2015-12-08 20:15:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506203002/20001
5 years ago (2015-12-08 20:22:14 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-09 02:53:49 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0671b967eb02d44c8951dc4dc39df09fac15b097

Powered by Google App Engine
This is Rietveld 408576698