Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1506013006: Re-add scrolling of the root frame for plugin windowRects. (Closed)

Created:
5 years ago by chrishtr
Modified:
5 years ago
Reviewers:
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-add scrolling of the root frame for plugin windowRects. This was mistakenly removed in https://codereview.chromium.org/1510083002. https://codereview.chromium.org/1508363002 makes this clear also. BUG=555381 TBR=wangxianzhu@chromium.org Committed: https://crrev.com/5f8fc8a0073845ad4eaa1209137991428ea7173a Cr-Commit-Position: refs/heads/master@{#364447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506013006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506013006/1
5 years ago (2015-12-10 18:52:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 20:09:25 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-10 20:10:51 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5f8fc8a0073845ad4eaa1209137991428ea7173a
Cr-Commit-Position: refs/heads/master@{#364447}

Powered by Google App Engine
This is Rietveld 408576698