Issue 15060008: Re-land r9059 with empty cityhash.gyp, instead of deleted cityhash.gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15060008: Re-land r9059 with empty cityhash.gyp, instead of deleted cityhash.gyp (Closed)

Created:
7 years, 7 months ago by epoger

Modified:
7 years, 7 months ago

Reviewers:
rmistry

CC:
skia-review_googlegroups.com, djsollen, borenet

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Re-land r9059 with empty cityhash.gyp, instead of deleted cityhash.gyp BUG=https://code.google.com/p/skia/issues/detail?id=1286 Committed: https://code.google.com/p/skia/source/detail?r=9064

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -213 lines)			Patch
M	DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	bench/ChecksumBench.cpp	View	5 chunks	+1 line, -22 lines	0 comments	Download
M	gm/gm_expectations.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	gyp/cityhash.gyp	View	1 chunk	+3 lines, -31 lines	0 comments	Download
M	gyp/utils.gyp	View	3 chunks	+0 lines, -14 lines	0 comments	Download
M	src/utils/SkBitmapHasher.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/utils/SkBitmapHasher.cpp	View	3 chunks	+0 lines, -18 lines	0 comments	Download
D	src/utils/SkCityHash.h	View	1 chunk	+0 lines, -47 lines	0 comments	Download
D	src/utils/SkCityHash.cpp	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	src/utils/cityhash/README	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	src/utils/cityhash/config.h	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	tests/ChecksumTest.cpp	View	4 chunks	+1 line, -28 lines	0 comments	Download

Total messages: 2 (0 generated)

epoger

Ravi- does this look OK to you? It succeeds locally (without a clean build), and ...

7 years, 7 months ago (2013-05-08 15:56:00 UTC) #1

LGTM