Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1505983005: Upgrade to analyzer 0.27.0. (Closed)

Created:
5 years ago by Bob Nystrom
Modified:
5 years ago
Reviewers:
Paul Berry, kevmoo
CC:
reviews_dartlang.org, nweiz, Brian Wilkerson
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Upgrade to analyzer 0.27.0. Also supports (and formats) the new config-specific code syntax. R=kevmoo@google.com, paulberry@google.com Committed: https://github.com/dart-lang/dart_style/commit/8b4b2c5bf43caf66aaa20d0a9a6a61bd0fc80b66

Patch Set 1 #

Patch Set 2 : Bump. #

Total comments: 2

Patch Set 3 : More upgrades. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -11 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M bin/format.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/src/dart_formatter.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/src/source_visitor.dart View 5 chunks +49 lines, -0 lines 0 comments Download
M pubspec.lock View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/comments/top_level.unit View 1 chunk +6 lines, -1 line 0 comments Download
M test/splitting/imports.unit View 1 chunk +22 lines, -1 line 0 comments Download
M test/whitespace/directives.unit View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Bob Nystrom
This gets dart_style happy with the latest analyzer. (And makes it *require* it. Older versions ...
5 years ago (2015-12-09 00:19:09 UTC) #2
Paul Berry
lgtm but see also the IM messages I sent you this afternoon
5 years ago (2015-12-09 00:27:33 UTC) #3
kevmoo
lgtm w/ one nit https://codereview.chromium.org/1505983005/diff/20001/pubspec.lock File pubspec.lock (right): https://codereview.chromium.org/1505983005/diff/20001/pubspec.lock#newcode155 pubspec.lock:155: version: "0.12.6" update test as ...
5 years ago (2015-12-09 00:59:24 UTC) #4
Bob Nystrom
Committed patchset #3 (id:40001) manually as 8b4b2c5bf43caf66aaa20d0a9a6a61bd0fc80b66 (presubmit successful).
5 years ago (2015-12-09 01:06:14 UTC) #6
Bob Nystrom
5 years ago (2015-12-09 01:06:25 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1505983005/diff/20001/pubspec.lock
File pubspec.lock (right):

https://codereview.chromium.org/1505983005/diff/20001/pubspec.lock#newcode155
pubspec.lock:155: version: "0.12.6"
On 2015/12/09 00:59:24, kevmoo wrote:
> update test as well

Done.

Powered by Google App Engine
This is Rietveld 408576698