[Sync] Remove ScopedServerStatusWatcher

sync/protocol/sync_enums.proto

Index: sync/protocol/sync_enums.proto
diff --git a/sync/protocol/sync_enums.proto b/sync/protocol/sync_enums.proto
index fa274595760e7c7aa7bc3ecf4575afacacb414a4..d8880dc9113e3b0d9a59b368419de0aac1cbb3eb 100644
--- a/sync/protocol/sync_enums.proto
+++ b/sync/protocol/sync_enums.proto
@@ -77,16 +77,14 @@ message SyncEnums {
 
   enum ErrorType {
     SUCCESS               = 0;
-    ACCESS_DENIED         = 1;  // Returned when the user doesn't have access to
-                                // store (instead of HTTP 401).
+    DEPRECATED_1          = 1;  // Was ACCESS_DENIED.

[Nicolas Zea, 2015/12/07 23:10:19]

I haven't seen this naming pattern before for deprecating protos. Did you get it
from somewhere in particular? Typically we either simply comment the field out
altogether, or keep the name but at the DEPTRECATED_ prefix.

[timonvo, 2015/12/07 23:15:17]

FWIW, we've used this pattern elsewhere on the server (and I think in some of
our protos here). I like it, since it removes any confusion and makes it clear
these values should not be used at all anymore.

Now you did make me think though, we should also add "[deprecated = true]" after
the tag number to be 100% complete.

     NOT_MY_BIRTHDAY       = 2;  // Returned when the server and client disagree
                                 // on the store birthday.
     THROTTLED             = 3;  // Returned when the store has exceeded the
                                 // allowed bandwidth utilization.
-    AUTH_EXPIRED          = 4;  // Auth token or cookie has expired.
-    USER_NOT_ACTIVATED    = 5;  // User doesn't have the Chrome bit set on that
-                                // Google Account.
-    AUTH_INVALID          = 6;  // Auth token or cookie is otherwise invalid.
+    DEPRECATED_4          = 4;  // Was AUTH_EXPIRED.
+    DEPRECATED_5          = 5;  // Was USER_NOT_ACTIVATED.
+    DEPRECATED_6          = 6;  // Was AUTH_INVALID.
     CLEAR_PENDING         = 7;  // A clear of the user data is pending (e.g.
                                 // initiated by privacy request).  Client should
                                 // come back later.