[Sync] Remove ScopedServerStatusWatcher

sync/protocol/sync_enums.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Sync protocol for communication between sync client and server.
 
 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
 // any fields in this file.
 
 syntax = "proto2";
@@ skipping 59 matching lines @@
   }
 
   // Types of redirects that triggered a transition.
   enum PageTransitionRedirectType {
     CLIENT_REDIRECT = 1;
     SERVER_REDIRECT = 2;
   }
 
   enum ErrorType {
     SUCCESS               = 0;
-    ACCESS_DENIED         = 1;  // Returned when the user doesn't have access to
-                                // store (instead of HTTP 401).
+    DEPRECATED_1          = 1;  // Was ACCESS_DENIED.

[Nicolas Zea, 2015/12/07 23:10:19]

I haven't seen this naming pattern before for deprecating protos. Did you get it
from somewhere in particular? Typically we either simply comment the field out
altogether, or keep the name but at the DEPTRECATED_ prefix.

[timonvo, 2015/12/07 23:15:17]

FWIW, we've used this pattern elsewhere on the server (and I think in some of
our protos here). I like it, since it removes any confusion and makes it clear
these values should not be used at all anymore.

Now you did make me think though, we should also add "[deprecated = true]" after
the tag number to be 100% complete.

     NOT_MY_BIRTHDAY       = 2;  // Returned when the server and client disagree
                                 // on the store birthday.
     THROTTLED             = 3;  // Returned when the store has exceeded the
                                 // allowed bandwidth utilization.
-    AUTH_EXPIRED          = 4;  // Auth token or cookie has expired.
-    USER_NOT_ACTIVATED    = 5;  // User doesn't have the Chrome bit set on that
-                                // Google Account.
-    AUTH_INVALID          = 6;  // Auth token or cookie is otherwise invalid.
+    DEPRECATED_4          = 4;  // Was AUTH_EXPIRED.
+    DEPRECATED_5          = 5;  // Was USER_NOT_ACTIVATED.
+    DEPRECATED_6          = 6;  // Was AUTH_INVALID.
     CLEAR_PENDING         = 7;  // A clear of the user data is pending (e.g.
                                 // initiated by privacy request).  Client should
                                 // come back later.
     TRANSIENT_ERROR       = 8;  // A transient error occured (eg. backend
                                 // timeout). Client should try again later.
     MIGRATION_DONE        = 9;  // Migration has finished for one or more data
                                 // types.  Client should clear the cache for
                                 // these data types only and then re-sync with
                                 // a server.
     DISABLED_BY_ADMIN    = 10;  // An administrator disabled sync for this
@@ skipping 60 matching lines @@
                            // user opted to sync a different set of datatypes.
     GU_TRIGGER = 12;  // The client is in 'normal' mode.  It may have several
                       // reasons for requesting an update.  See the per-type
                       // GetUpdateTriggers message for more details.
     RETRY = 13;  // A retry GU to pick up updates missed by last GU due to
                  // replication delay, missing hints, etc.
     PROGRAMMATIC = 14;     // A GU to programmatically enable/disable a
                            // datatype, often due to error handling.
   }
 }