Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2414)

Unified Diff: chrome/android/java/res/values-v17/styles.xml

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a couple of bugs Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/values-v17/styles.xml
diff --git a/chrome/android/java/res/values-v17/styles.xml b/chrome/android/java/res/values-v17/styles.xml
index aedff9c655c32f9061ab20890193ee2fd4e99eeb..50ced1f4ce4b6f12fa91c099d1fa14ae79ac559f 100644
--- a/chrome/android/java/res/values-v17/styles.xml
+++ b/chrome/android/java/res/values-v17/styles.xml
@@ -465,4 +465,18 @@
<item name="android:layout_height">56dp</item>
<item name="android:scaleType">center</item>
</style>
+ <style name="AppMenuItem">
+ <item name="android:paddingStart">16dp</item>
+ <item name="android:paddingEnd">16dp</item>
+ <item name="android:background">?attr/listChoiceBackgroundIndicator</item>
+ </style>
+ <style name="UpdateMenuBadge">
+ <item name="android:layout_height">@dimen/menu_badge_size</item>
+ <item name="android:layout_width">@dimen/menu_badge_size</item>
+ <item name="android:layout_gravity">end|bottom</item>
+ <item name="android:layout_marginBottom">14dp</item>
+ <item name="android:focusable">false</item>
+ <item name="android:importantForAccessibility">no</item>
+ <item name="android:visibility">invisible</item>
Theresa 2015/12/10 21:22:53 I changed this from gone to invisible so that the
gone 2015/12/10 21:45:09 Acknowledged.
Theresa 2015/12/11 19:44:46 I discussed this w/ newt@ offline and I think maki
+ </style>
</resources>

Powered by Google App Engine
This is Rietveld 408576698