Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <resources xmlns:tools="http://schemas.android.com/tools"> | 6 <resources xmlns:tools="http://schemas.android.com/tools"> |
| 7 <!-- Q: Why put style resources under values-v17/ ? | 7 <!-- Q: Why put style resources under values-v17/ ? |
| 8 A: Problem: | 8 A: Problem: |
| 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. | 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. |
| 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert | 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert |
| (...skipping 447 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 458 </style> | 458 </style> |
| 459 <style name="LocationBarButton"> | 459 <style name="LocationBarButton"> |
| 460 <item name="android:background">@null</item> | 460 <item name="android:background">@null</item> |
| 461 </style> | 461 </style> |
| 462 <style name="ToolbarButton"> | 462 <style name="ToolbarButton"> |
| 463 <item name="android:background">?attr/selectableItemBackground</item> | 463 <item name="android:background">?attr/selectableItemBackground</item> |
| 464 <item name="android:layout_width">48dp</item> | 464 <item name="android:layout_width">48dp</item> |
| 465 <item name="android:layout_height">56dp</item> | 465 <item name="android:layout_height">56dp</item> |
| 466 <item name="android:scaleType">center</item> | 466 <item name="android:scaleType">center</item> |
| 467 </style> | 467 </style> |
| 468 <style name="AppMenuItem"> | |
| 469 <item name="android:paddingStart">16dp</item> | |
| 470 <item name="android:paddingEnd">16dp</item> | |
| 471 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m> | |
| 472 </style> | |
| 473 <style name="UpdateMenuBadge"> | |
| 474 <item name="android:layout_height">@dimen/menu_badge_size</item> | |
| 475 <item name="android:layout_width">@dimen/menu_badge_size</item> | |
| 476 <item name="android:layout_gravity">end|bottom</item> | |
| 477 <item name="android:layout_marginBottom">14dp</item> | |
| 478 <item name="android:focusable">false</item> | |
| 479 <item name="android:importantForAccessibility">no</item> | |
| 480 <item name="android:visibility">invisible</item> | |
|
Theresa
2015/12/10 21:22:53
I changed this from gone to invisible so that the
gone
2015/12/10 21:45:09
Acknowledged.
Theresa
2015/12/11 19:44:46
I discussed this w/ newt@ offline and I think maki
| |
| 481 </style> | |
| 468 </resources> | 482 </resources> |
| OLD | NEW |