chrome/android/java/res/layout/toolbar.xml - Issue 1505913003: Add update menu item and app menu icon badge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/toolbar.xml

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add code create 1dp transparent border in LocatoinBarPhone Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/layout-sw600dp/toolbar.xml ('K') | « chrome/android/java/res/layout/menu_item.xml ('k') | chrome/android/java/res/layout/update_menu_item.xml » ('j') | chrome/android/java/res/layout/update_menu_item.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/toolbar.xml

diff --git a/chrome/android/java/res/layout/toolbar.xml b/chrome/android/java/res/layout/toolbar.xml

index 0ab520e2241e6fec5ec19ef67313c707e89ab78e..0ae4a9159fdec73ea5cdc6c661e35c1da2b0512a 100644

--- a/chrome/android/java/res/layout/toolbar.xml

+++ b/chrome/android/java/res/layout/toolbar.xml

@@ -48,15 +48,30 @@

style="@style/ToolbarButton"

android:layout_gravity="top"

android:contentDescription="@string/accessibility_toolbar_btn_tabswitcher_toggle" />

- <org.chromium.chrome.browser.widget.TintedImageButton

- android:id="@+id/menu_button"

- style="@style/ToolbarButton"

- android:layout_gravity="top"

- android:layout_width="42dp"

- android:paddingEnd="4dp"

- android:src="@drawable/btn_menu"

- android:contentDescription="@string/accessibility_toolbar_btn_menu"

- android:background="@null" />

+ <FrameLayout

+ android:layout_width="wrap_content"

+ android:layout_height="wrap_content"

+ android:id="@+id/menu_btn_wrapper" >

+ <org.chromium.chrome.browser.widget.TintedImageButton

+ android:id="@+id/menu_button"

+ style="@style/ToolbarButton"

+ android:layout_gravity="top"

+ android:layout_width="42dp"

+ android:paddingEnd="4dp"

+ android:src="@drawable/btn_menu"

+ android:contentDescription="@string/accessibility_toolbar_btn_menu"

+ android:background="@null" />

+ <ImageView

+ android:id="@+id/menu_badge"

+ android:src="@drawable/badge_update"

+ android:layout_height="@dimen/menu_badge_size"

+ android:layout_width="@dimen/menu_badge_size"

+ android:layout_marginBottom="14dp"

+ android:layout_marginEnd="10dp"

+ android:layout_gravity="end|bottom"

+ android:contentDescription="@string/accessibility_toolbar_update_badge"

+ android:visibility="gone" />

+ </FrameLayout>

</LinearLayout>

<org.chromium.chrome.browser.widget.ToolbarProgressBar

android:id="@+id/progress"