chrome/android/java/res/layout/menu_item.xml - Issue 1505913003: Add update menu item and app menu icon badge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/menu_item.xml

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add code create 1dp transparent border in LocatoinBarPhone Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/menu_item.xml

diff --git a/chrome/android/java/res/layout/menu_item.xml b/chrome/android/java/res/layout/menu_item.xml

index 668c7e5531b7b0facf35a1e282cd8a34d39cdd29..2113d1ede282877bfa89e3e6e93ef69a3fe4fefc 100644

--- a/chrome/android/java/res/layout/menu_item.xml

+++ b/chrome/android/java/res/layout/menu_item.xml

@@ -6,11 +6,9 @@

-->

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

+ style="@style/AppMenuItem"

android:layout_width="match_parent"

- android:layout_height="?android:attr/listPreferredItemHeightSmall"

- android:paddingStart="16dp"

- android:paddingEnd="16dp"

- android:background="?attr/listChoiceBackgroundIndicator">

+ android:layout_height="?android:attr/listPreferredItemHeightSmall" >

<TextView

android:id="@+id/menu_item_text"

android:textAppearance="?android:attr/textAppearanceLargePopupMenu"