Issue 15059007: Disabling ExtensionApiTest.TabHighlight for being flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15059007: Disabling ExtensionApiTest.TabHighlight for being flaky. (Closed)

Created:
7 years, 7 months ago by vabr (Chromium)

Modified:
7 years, 7 months ago

Reviewers:
jstritar

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disabling ExtensionApiTest.TabHighlight for being flaky. BUG=239022 TBR=jstritar Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198886

Patch Set 1 #

Patch Set 2 : Added a crbug number #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/browser/extensions/extension_tabs_apitest.cc	View	1	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vabr (Chromium)

Committed patchset #2 manually as r198886 (presubmit successful).

7 years, 7 months ago (2013-05-08 13:16:48 UTC) #1

jstritar

7 years, 7 months ago (2013-05-08 13:54:03 UTC) #2

LGTM
On May 8, 2013 9:16 AM, <vabr@chromium.org> wrote:

> Reviewers: jstritar,
>
> Message:
> Committed patchset #2 manually as r198886 (presubmit successful).
>
> Description:
> Disabling ExtensionApiTest.TabHighlight for being flaky.
>
> BUG=239022
> TBR=jstritar
>
> Committed: https://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=198886<https://src.chromium.org/viewvc/chrome?view=rev&revision=198886>
>
> Please review this at
https://codereview.chromium.**org/15059007/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/extensions/**extension_tabs_apitest.cc
>
>
> Index: chrome/browser/extensions/**extension_tabs_apitest.cc
> diff --git a/chrome/browser/extensions/**extension_tabs_apitest.cc
> b/chrome/browser/extensions/**extension_tabs_apitest.cc
> index 9ff406cbaa8b71ae7573a12305e64e**e4fe3fe839..**
> df04ad05b462306811d1ed5c851c63**0f0e939c23 100644
> --- a/chrome/browser/extensions/**extension_tabs_apitest.cc
> +++ b/chrome/browser/extensions/**extension_tabs_apitest.cc
> @@ -129,7 +129,13 @@ IN_PROC_BROWSER_TEST_F(**ExtensionApiTest, TabQuery)
> {
>    ASSERT_TRUE(**RunExtensionSubtest("tabs/**basics", "query.html")) <<
> message_;
>  }
>
> -IN_PROC_BROWSER_TEST_F(**ExtensionApiTest, TabHighlight) {
> +// Flaky on windows: http://crbug.com/239022
> +#if defined(OS_WIN)
> +#define MAYBE_TabHighlight DISABLED_TabHighlight
> +#else
> +#define MAYBE_TabHighlight TabHighlight
> +#endif
> +IN_PROC_BROWSER_TEST_F(**ExtensionApiTest, MAYBE_TabHighlight) {
>    ASSERT_TRUE(**RunExtensionSubtest("tabs/**basics", "highlight.html"))
> << message_;
>  }
>
>
>
>

Expand Messages | Collapse Messages