Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Side by Side Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 15059007: Disabling ExtensionApiTest.TabHighlight for being flaky. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added a crbug number Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_apitest.h" 5 #include "chrome/browser/extensions/extension_apitest.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "chrome/browser/prefs/incognito_mode_prefs.h" 8 #include "chrome/browser/prefs/incognito_mode_prefs.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 122
123 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_TabRelativeURLs) { 123 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_TabRelativeURLs) {
124 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "relative_urls.html")) 124 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "relative_urls.html"))
125 << message_; 125 << message_;
126 } 126 }
127 127
128 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabQuery) { 128 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabQuery) {
129 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "query.html")) << message_; 129 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "query.html")) << message_;
130 } 130 }
131 131
132 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabHighlight) { 132 // Flaky on windows: http://crbug.com/239022
133 #if defined(OS_WIN)
134 #define MAYBE_TabHighlight DISABLED_TabHighlight
135 #else
136 #define MAYBE_TabHighlight TabHighlight
137 #endif
138 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_TabHighlight) {
133 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "highlight.html")) << message_; 139 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "highlight.html")) << message_;
134 } 140 }
135 141
136 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabCrashBrowser) { 142 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabCrashBrowser) {
137 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crash.html")) << message_; 143 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crash.html")) << message_;
138 } 144 }
139 145
140 // Flaky on windows: http://crbug.com/238667 146 // Flaky on windows: http://crbug.com/238667
141 #if defined(OS_WIN) 147 #if defined(OS_WIN)
142 #define MAYBE_TabOpener DISABLED_TabOpener 148 #define MAYBE_TabOpener DISABLED_TabOpener
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 << message_; 275 << message_;
270 } 276 }
271 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) { 277 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) {
272 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html")) 278 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))
273 << message_; 279 << message_;
274 } 280 }
275 281
276 // Adding a new test? Awesome. But API tests are the old hotness. The 282 // Adding a new test? Awesome. But API tests are the old hotness. The
277 // new hotness is extension_test_utils. See tabs_test.cc for an example. 283 // new hotness is extension_test_utils. See tabs_test.cc for an example.
278 // We are trying to phase out many uses of API tests as they tend to be flaky. 284 // We are trying to phase out many uses of API tests as they tend to be flaky.
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698