Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1505803004: Disable soon to be deprecated APIs per default for v8 (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable soon to be deprecated APIs per default for v8 Embedders still can use those APIs by default test-api.cc still has an exception to use the old APIs... BUG=v8:4143 R=vogelheim@chromium.org LOG=n Committed: https://crrev.com/6f472db65a69c5cd6a885af8a2ebad8c460a22c1 Cr-Commit-Position: refs/heads/master@{#32701}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -513 lines) Patch
M build/standalone.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M samples/samples.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/d8.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/third_party/vtune/v8vtune.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/cctest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/codegen-tester.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-basic-block-profiler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-branch-combine.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-code-stub-assembler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-graph-visualizer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-loop-analysis.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-loop-assignment-analysis.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-multiple-return.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-node.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-operator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-osr.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-pipeline.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-deopt.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-jsbranches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-jsobjects.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-jsops.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-properties.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-stackcheck.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-stubs.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-variables.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/expression-type-collector.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/gay-fixed.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/gay-precision.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/gay-shortest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/print-extension.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/profiler-extension.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-api-accessors.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-array-list.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-ppc.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-x87.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-ast.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-ast-expression-visitor.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-atomicops.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-bignum.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-bignum-dtoa.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-bit-vector.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-circular-queue.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-code-stubs.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-code-stubs-arm.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-code-stubs-arm64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-code-stubs-ia32.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-code-stubs-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-code-stubs-mips64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-code-stubs-x64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-code-stubs-x87.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-constantpool.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-conversions.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-date.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-decls.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-dictionary.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-disasm-arm64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-disasm-mips64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-disasm-ppc.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-disasm-x87.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-diy-fp.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-double.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-dtoa.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-elements-kind.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-fast-dtoa.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-fixed-dtoa.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-func-name-inference.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-fuzz-arm64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-gc-tracer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-global-handles.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-global-object.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-hashing.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-hashmap.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-hydrogen-types.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-identity-map.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-incremental-marking.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-inobject-slack-tracking.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-javascript-arm64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-js-arm64-variables.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-list.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-liveedit.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-lockers.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-macro-assembler-arm.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-macro-assembler-ia32.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-macro-assembler-mips64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-macro-assembler-x87.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-mementos.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-microtask-delivery.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-platform.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-platform-linux.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-platform-win32.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-random-number-generator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-reloc-info.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-representation.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-sampler-api.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-simd.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-slots-buffer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-strtod.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-symbols.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-transitions.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-typedarrays.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-types.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-typing-reset.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-unbound-queue.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-unique.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-unscopables-hidden-prototype.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-utils.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-utils-arm64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-version.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-weaksets.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/trace-extension.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-12-09 09:17:59 UTC) #1
vogelheim
lgtm. \o/
5 years ago (2015-12-09 09:31:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505803004/1
5 years ago (2015-12-09 09:39:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 10:34:18 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-09 10:35:17 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6f472db65a69c5cd6a885af8a2ebad8c460a22c1
Cr-Commit-Position: refs/heads/master@{#32701}

Powered by Google App Engine
This is Rietveld 408576698