Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 150543002: Remove ASM_UNIMPLEMENTED from Builtins::Generate_FunctionCall (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
Reviewers:
baptiste.afsa1, ulan
CC:
v8-dev
Visibility:
Public.

Description

Remove ASM_UNIMPLEMENTED from Builtins::Generate_FunctionCall It's actually called by several tests, for example with var a = {}; a.call = Function.prototype.call; a.call(); In contrast to the _BREAK() variant ASM_UNIMPLEMENTED() doesn't trigger any visible output, so it's not readily obvious that this code path is actually taken BUG=none R=baptiste.afsa@arm.com, ulan@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/a64/builtins-a64.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-01-30 16:42:40 UTC) #1
ulan
lgtm
6 years, 10 months ago (2014-01-30 16:43:41 UTC) #2
baptiste.afsa1
lgtm
6 years, 10 months ago (2014-01-30 17:04:23 UTC) #3
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-01-30 19:01:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r18963 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698