Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: src/a64/builtins-a64.cc

Issue 150543002: Remove ASM_UNIMPLEMENTED from Builtins::Generate_FunctionCall (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1098 matching lines...) Expand 10 before | Expand all | Expand 10 after
1109 __ Drop(1); 1109 __ Drop(1);
1110 } 1110 }
1111 1111
1112 // 5a. Call non-function via tail call to CALL_NON_FUNCTION builtin, 1112 // 5a. Call non-function via tail call to CALL_NON_FUNCTION builtin,
1113 // or a function proxy via CALL_FUNCTION_PROXY. 1113 // or a function proxy via CALL_FUNCTION_PROXY.
1114 // x0: actual number of arguments 1114 // x0: actual number of arguments
1115 // x1: function 1115 // x1: function
1116 // x4: call type (0: JS function, 1: function proxy, 2: non-function) 1116 // x4: call type (0: JS function, 1: function proxy, 2: non-function)
1117 { Label function, non_proxy; 1117 { Label function, non_proxy;
1118 __ Cbz(x4, &function); 1118 __ Cbz(x4, &function);
1119 ASM_UNIMPLEMENTED("Builtins::Generate_FunctionCall non-function");
1120 // Expected number of arguments is 0 for CALL_NON_FUNCTION. 1119 // Expected number of arguments is 0 for CALL_NON_FUNCTION.
1121 __ Mov(x2, 0); 1120 __ Mov(x2, 0);
1122 __ SetCallKind(x5, CALL_AS_METHOD); 1121 __ SetCallKind(x5, CALL_AS_METHOD);
1123 __ Cmp(x4, 1); 1122 __ Cmp(x4, 1);
1124 __ B(ne, &non_proxy); 1123 __ B(ne, &non_proxy);
1125 1124
1126 __ Push(x1); // Re-add proxy object as additional argument. 1125 __ Push(x1); // Re-add proxy object as additional argument.
1127 __ Add(x0, x0, 1); 1126 __ Add(x0, x0, 1);
1128 __ GetBuiltinEntry(x3, Builtins::CALL_FUNCTION_PROXY); 1127 __ GetBuiltinEntry(x3, Builtins::CALL_FUNCTION_PROXY);
1129 __ Jump(masm->isolate()->builtins()->ArgumentsAdaptorTrampoline(), 1128 __ Jump(masm->isolate()->builtins()->ArgumentsAdaptorTrampoline(),
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
1459 __ Bind(&dont_adapt_arguments); 1458 __ Bind(&dont_adapt_arguments);
1460 __ Jump(x3); 1459 __ Jump(x3);
1461 } 1460 }
1462 1461
1463 1462
1464 #undef __ 1463 #undef __
1465 1464
1466 } } // namespace v8::internal 1465 } } // namespace v8::internal
1467 1466
1468 #endif // V8_TARGET_ARCH_ARM 1467 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698