Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1505353007: Disable enumeration caching for output devices. (Closed)

Created:
5 years ago by Guido Urdaneta
Modified:
5 years ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable enumeration caching for output devices. BUG=568139 Committed: https://crrev.com/b66b8bdd7874c0ac82a5ce88ca50c6d9406ef6a1 Cr-Commit-Position: refs/heads/master@{#365223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -14 lines) Patch
M content/browser/renderer_host/media/audio_output_device_enumerator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_output_device_enumerator.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 2 chunks +35 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 28 (13 generated)
Guido Urdaneta
Hi, PTAL. This one disables enumerator caching and also disables use of the enumerator when ...
5 years ago (2015-12-10 17:57:21 UTC) #3
Guido Urdaneta
5 years ago (2015-12-10 17:58:39 UTC) #5
Guido Urdaneta
On 2015/12/10 17:58:39, Guido Urdaneta wrote: Apart from caching, this one also removes the use ...
5 years ago (2015-12-10 18:13:40 UTC) #6
Guido Urdaneta
On 2015/12/10 17:58:39, Guido Urdaneta wrote: Apart from caching, this one also removes the use ...
5 years ago (2015-12-10 18:13:43 UTC) #7
DaleCurtis
What did you think about my proposal to invalidate cache via AudioManager output change listener? ...
5 years ago (2015-12-10 18:49:21 UTC) #8
Guido Urdaneta
On 2015/12/10 18:49:21, DaleCurtis wrote: > What did you think about my proposal to invalidate ...
5 years ago (2015-12-10 20:22:11 UTC) #9
Guido Urdaneta
Should we land this?
5 years ago (2015-12-14 19:52:37 UTC) #10
DaleCurtis
Yes it sounds like we shouldn't be doing this until we have signals for invalidation ...
5 years ago (2015-12-14 20:00:20 UTC) #11
DaleCurtis
lgtm
5 years ago (2015-12-14 20:00:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505353007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505353007/1
5 years ago (2015-12-14 20:17:23 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/110522)
5 years ago (2015-12-15 02:51:20 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505353007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505353007/1
5 years ago (2015-12-15 07:21:23 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505353007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505353007/1
5 years ago (2015-12-15 10:54:12 UTC) #24
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 10:58:52 UTC) #26
commit-bot: I haz the power
5 years ago (2015-12-15 10:59:48 UTC) #28
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b66b8bdd7874c0ac82a5ce88ca50c6d9406ef6a1
Cr-Commit-Position: refs/heads/master@{#365223}

Powered by Google App Engine
This is Rietveld 408576698