Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1527)

Unified Diff: content/browser/renderer_host/media/audio_renderer_host.cc

Issue 1505353007: Disable enumeration caching for output devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_renderer_host.cc
diff --git a/content/browser/renderer_host/media/audio_renderer_host.cc b/content/browser/renderer_host/media/audio_renderer_host.cc
index 40d1adacd6521825532edd3ce8b97f078d24e800..92196ab70b158abfa7f9592e8e30518cc5659262 100644
--- a/content/browser/renderer_host/media/audio_renderer_host.cc
+++ b/content/browser/renderer_host/media/audio_renderer_host.cc
@@ -99,6 +99,22 @@ bool IsValidDeviceId(const std::string& device_id) {
return true;
}
+bool IsDefaultDeviceId(const std::string& device_id) {
+ return device_id.empty() ||
+ device_id == media::AudioManagerBase::kDefaultDeviceId;
+}
+
+AudioOutputDeviceInfo GetDefaultDeviceInfoOnDeviceThread(
+ media::AudioManager* audio_manager) {
+ DCHECK(audio_manager->GetWorkerTaskRunner()->BelongsToCurrentThread());
+ AudioOutputDeviceInfo default_device_info = {
+ media::AudioManagerBase::kDefaultDeviceId,
+ audio_manager->GetDefaultDeviceName(),
+ audio_manager->GetDefaultOutputStreamParameters()};
+
+ return default_device_info;
+}
+
void NotifyRenderProcessHostThatAudioStateChanged(int render_process_id) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ -460,10 +476,25 @@ void AudioRendererHost::OnDeviceAuthorized(int stream_id,
return;
}
- media_stream_manager_->audio_output_device_enumerator()->Enumerate(base::Bind(
- &AudioRendererHost::TranslateDeviceID, this, device_id,
- gurl_security_origin,
- base::Bind(&AudioRendererHost::OnDeviceIDTranslated, this, stream_id)));
+ // If enumerator caching is disabled, avoid the enumeration if the default
+ // device is requested, since no device ID translation is needed.
+ // If enumerator caching is enabled, it is better to use its cache, even
+ // for the default device.
+ if (IsDefaultDeviceId(device_id) &&
+ !media_stream_manager_->audio_output_device_enumerator()
+ ->IsCacheEnabled()) {
+ base::PostTaskAndReplyWithResult(
+ audio_manager_->GetWorkerTaskRunner().get(), FROM_HERE,
+ base::Bind(&GetDefaultDeviceInfoOnDeviceThread, audio_manager_),
+ base::Bind(&AudioRendererHost::OnDeviceIDTranslated, this, stream_id,
+ true));
+ } else {
+ media_stream_manager_->audio_output_device_enumerator()->Enumerate(
+ base::Bind(&AudioRendererHost::TranslateDeviceID, this, device_id,
+ gurl_security_origin,
+ base::Bind(&AudioRendererHost::OnDeviceIDTranslated, this,
+ stream_id)));
+ }
}
void AudioRendererHost::OnDeviceIDTranslated(

Powered by Google App Engine
This is Rietveld 408576698