Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 1505353005: Stop using the ANGLE D3D11 device for H/W decoding on Windows 8+ (Closed)

Created:
5 years ago by ananta
Modified:
5 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop using the ANGLE D3D11 device for H/W decoding on Windows 8+ It looks like there are bugs in some GPU drivers like nvidia which causes the D3D11 context state to get messed up when accessed from multiple threads. This inspite of us following the documented way of accessing the context from multiple threads by enabling multi threaded mode. This change reverts back to the old model of creating a D3D11 device per decoder instance. The ANGLE device continues to be used for D3D9 based decoding on Windows 7, which will kick in if D3D11 is not available on that platform. BUG=548383 TBR=dalecurtis Committed: https://crrev.com/8d746f4bc6f34c318eb24edf33a6e8e5dfd6eb94 Cr-Commit-Position: refs/heads/master@{#364272}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -41 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator_win.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator_win.cc View 1 7 chunks +66 lines, -41 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (7 generated)
ananta
5 years ago (2015-12-09 20:34:36 UTC) #2
DaleCurtis
Is it worth exploring the COM initializer to see if we should be using MTA ...
5 years ago (2015-12-09 20:54:25 UTC) #3
Ken Russell (switch to Gerrit)
On 2015/12/09 20:54:25, DaleCurtis wrote: > Is it worth exploring the COM initializer to see ...
5 years ago (2015-12-09 21:03:16 UTC) #4
DaleCurtis
=>sandersd for review.
5 years ago (2015-12-09 21:07:19 UTC) #6
ananta
On 2015/12/09 20:54:25, DaleCurtis wrote: > Is it worth exploring the COM initializer to see ...
5 years ago (2015-12-09 22:42:11 UTC) #7
ananta
On 2015/12/09 22:42:11, ananta wrote: > On 2015/12/09 20:54:25, DaleCurtis wrote: > > Is it ...
5 years ago (2015-12-09 22:58:08 UTC) #8
sandersd (OOO until July 31)
lgtm https://codereview.chromium.org/1505353005/diff/1/content/common/gpu/media/dxva_video_decode_accelerator_win.cc File content/common/gpu/media/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/1505353005/diff/1/content/common/gpu/media/dxva_video_decode_accelerator_win.cc#newcode790 content/common/gpu/media/dxva_video_decode_accelerator_win.cc:790: // 9.1 unless otherwise stated by the application, ...
5 years ago (2015-12-09 23:02:49 UTC) #9
ananta
https://codereview.chromium.org/1505353005/diff/1/content/common/gpu/media/dxva_video_decode_accelerator_win.cc File content/common/gpu/media/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/1505353005/diff/1/content/common/gpu/media/dxva_video_decode_accelerator_win.cc#newcode790 content/common/gpu/media/dxva_video_decode_accelerator_win.cc:790: // 9.1 unless otherwise stated by the application, which ...
5 years ago (2015-12-09 23:15:03 UTC) #10
ananta
5 years ago (2015-12-09 23:15:04 UTC) #11
ananta
TBR'ing dalecurtis. Will address comments in a follow up
5 years ago (2015-12-10 00:35:18 UTC) #13
DaleCurtis
Dan's lgtm should be enough, but here's mine.
5 years ago (2015-12-10 02:17:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1505353005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1505353005/20001
5 years ago (2015-12-10 03:44:08 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 03:50:09 UTC) #19
commit-bot: I haz the power
5 years ago (2015-12-10 03:51:03 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d746f4bc6f34c318eb24edf33a6e8e5dfd6eb94
Cr-Commit-Position: refs/heads/master@{#364272}

Powered by Google App Engine
This is Rietveld 408576698