third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js - Issue 1505023004: ServiceWorker: Early reject error if url is something wrong.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js

Issue 1505023004: ServiceWorker: Early reject error if url is something wrong. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js

index 0db803c7c4e86fe8db7713046536e7ca174e24c7..68e7e148a194f9ca580077a3cfcd7f082b4b6c93 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js

@@ -49,18 +49,18 @@ var TESTS = [

function testOpenAboutBlank() {

synthesizeNotificationClick().then(function(e) {

- clients.openWindow('about:blank').then(function(c) {

+ clients.openWindow('about:blank').catch(function(error) {

self.postMessage('openWindow() can open about:blank');

- self.postMessage('openWindow() result: ' + c);

+ self.postMessage('openWindow() error is: ' + error.name);

}).then(runNextTestOrQuit);

});

function testOpenAboutCrash() {

synthesizeNotificationClick().then(function(e) {

- clients.openWindow('about:crash').then(function(c) {

+ clients.openWindow('about:crash').catch(function(error) {

self.postMessage('openWindow() can open about:crash');

- self.postMessage('openWindow() result: ' + c);

+ self.postMessage('openWindow() error is: ' + error.name);

}).then(runNextTestOrQuit);

});