third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp - Issue 1505023004: ServiceWorker: Early reject error if url is something wrong.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

Issue 1505023004: ServiceWorker: Early reject error if url is something wrong. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/clients-openwindow.js ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

index 4533f1f8995a1b0a63d470d3997f0532af84e761..0b581f05bc2628bdc4f6e428c1281d2c405d21c3 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

@@ -112,7 +112,7 @@ ScriptPromise ServiceWorkerClients::openWindow(ScriptState* scriptState, const S

ExecutionContext* context = scriptState->executionContext();

KURL parsedUrl = KURL(toWorkerGlobalScope(context)->location()->url(), url);

- if (!parsedUrl.isValid()) {

+ if (!parsedUrl.isValid() || !parsedUrl.protocolIsInHTTPFamily()) {

resolver->reject(V8ThrowException::createTypeError(scriptState->isolate(), "'" + url + "' is not a valid URL."));

return promise;

}